feat(config-updator): pin typescript in module config - #25
Draft
TomChv wants to merge 2 commits into
Draft
Conversation
Module codegen needs the same package.json/tsconfig/deno.json writers init already has — they were the module writers all along, just missing the one thing codegen adds: the typescript pin. It is not cosmetic. The runtime mounts its own prebuilt compiler, and skips dependency installation entirely for an otherwise dependency-free module, only when the pin matches the engine's default; without it every `dagger call` pays for a package-manager install. Deno has no node_modules to fall back on, so it gets the same pin through its import map. Both use setIfNotExists, so a module that picked its own version keeps it and accepts the install rather than being silently retargeted. Existing expectations updated for the new output, with explicit cases for the preservation path. Signed-off-by: Tom Chauveau <tom@dagger.io>
A module's generated package.json and tsconfig.json came out on a single line.
sjson edits in place, which reads as "preserve the user's formatting" but only
holds for the parts it does not touch: keys it adds are appended compactly, and
a file created from scratch — every fresh module — comes out entirely inlined.
Indent everything we write instead, key order preserved. This reformats an
existing file's whitespace, which is a real cost, but these are committed config
files people read and edit; emitting them minified is worse.
Two init assertions had encoded the old output shape ("type":"module" with no
space) and now read the way the file does.
Signed-off-by: Tom Chauveau <tom@dagger.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module codegen needs the same package.json/tsconfig/deno.json writers init
already has — they were the module writers all along, just missing the one
thing codegen adds: the typescript pin.
It is not cosmetic. The runtime mounts its own prebuilt compiler, and skips
dependency installation entirely for an otherwise dependency-free module, only
when the pin matches the engine's default; without it every
dagger callpaysfor a package-manager install. Deno has no node_modules to fall back on, so it
gets the same pin through its import map.
Both use setIfNotExists, so a module that picked its own version keeps it and
accepts the install rather than being silently retargeted. Existing
expectations updated for the new output, with explicit cases for the
preservation path.
Signed-off-by: Tom Chauveau tom@dagger.io
Stack created with GitHub Stacks CLI • Give Feedback 💬