Repository navigation
Conversation
Motivation: As pNFS layouts are independent of file open, they are invalidated only when layout return is issued. The door logic creates a transfer, adds transfer into transfers list and then performs namespace lookup, pool selection and starting a mover. In cases, when pool selection fails due to stage protection or an attempt to overwrite, the layout get will return "permission deny", thus layout return will never be issued and transfer will stay in the door forever. Modification: Update layoutGet error handling such that on permission deny error pool less transfers will be removed. An unexpected conditions are logged. Result: orphan transfers like "WriteTransfer null@N/A," are removed when it's safe. Acked-by: Marina Sahakyan Target: master, 12.0, 11.2 Require-book: no Require-notes: yes (cherry picked from commit ecdd82e) Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
As pNFS layouts are independent of file open, they are invalidated only when layout return is issued. The door logic creates a transfer, adds transfer into transfers list and then performs namespace lookup, pool selection and starting a mover. In cases, when pool selection fails due to stage protection or an attempt to overwrite, the layout get will return "permission deny", thus layout return will never be issued and transfer will stay in the door forever.
Modification:
Update layoutGet error handling such that on permission deny error pool less transfers will be removed. An unexpected conditions are logged.
Result:
orphan transfers like "WriteTransfer null@N/A," are removed when it's safe.
Acked-by: Marina Sahakyan
Target: master, 12.0, 11.2
Require-book: no
Require-notes: yes
(cherry picked from commit ecdd82e)