Skip to content

nfs: remove transfer from the door list if pool selection failed #8249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kofemann wants to merge 1 commit into
base: 11.2
Choose a base branch
from
Open

nfs: remove transfer from the door list if pool selection failed #8249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions modules/dcache-nfs/src/main/java/org/dcache/chimera/nfsv41/door/NFSv41Door.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,6 +807,7 @@ public Layout layoutGet(CompoundContext context, LAYOUTGET4args args)
final stateid4 stateid = Stateids.getCurrentStateidIfNeeded(context, args.loga_stateid);

LayoutDriver layoutDriver = getLayoutDriver(layoutType);
NfsTransfer transfer = null;

final NFS4Client client;
if (context.getMinorversion() == 0) {
Expand Down Expand Up @@ -840,7 +841,7 @@ public Layout layoutGet(CompoundContext context, LAYOUTGET4args args)
throw new LayoutUnavailableException("special DOT file");
}

NfsTransfer transfer = layoutStateid != null ? _transfers.get(layoutStateid) : null;
transfer = layoutStateid != null ? _transfers.get(layoutStateid) : null;
if (transfer == null) {
Transfer.initSession(false, false);
NDC.push(pnfsId.toString());
Expand Down Expand Up @@ -917,6 +918,20 @@ public Layout layoutGet(CompoundContext context, LAYOUTGET4args args)
*/
client.releaseState(stateid);
throw new StaleException("File is removed", e);
} catch (PermissionDeniedCacheException e) {
// pool selection due to stage protection or an overwrite attempt of an existing file.
if (transfer.getPool() == null) {
// safe to forget
_log.error("Removing pool-less transfer for client {} for file {}: {}",
toAddrString(context.getRemoteSocketAddress().getAddress()),
transfer.getPnfsId(), e.getMessage());
_transfers.remove(transfer.getStateid().stateid());
} else {
// should never happen
_log.error("Report to support@dcache.org: Unexpected permission denied for transfer {} with assigned pool: {}", transfer, e.toString());
}

throw new PermException(e.getMessage(), e);
} catch (CacheException | ChimeraFsException | TimeoutException | ExecutionException e) {
throw asNfsException(e, LayoutTryLaterException.class);
} catch (InterruptedException e) {
Expand Down Expand Up @@ -1532,7 +1547,7 @@ deviceid4[] selectDataServers(long timeout) throws
* allow writes only into new files
*/
if (!attr.getStorageInfo().isCreatedOnly()) {
throw new PermException("Can't modify existing file");
throw new PermissionDeniedCacheException("Can't modify existing file");
}

// REVISIT: this have to go into Transfer class.
Expand Down
Loading