Conversation
Monero payment URIs can list several recipients, e.g. `monero:A;B?tx_amount=1;2&recipient_name=x;y`. Parse these into PaymentUriData.recipients, requiring one amount (and, when given, one name) per address. Callers must opt in with allowMultipleRecipients, so screens that handle a single address never drop recipients silently. On the mobile and desktop send screens, a scanned, pasted, or typed multi-recipient URI replaces the address field with a read-only list of recipients, locks the amount to their total, and builds one transaction with an output per recipient. Clear returns to the normal form. The confirmation screen lists every recipient with its amount. confirm_transaction_view.dart is also run through dart format, as the changed-files format check requires.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Monero payment URIs can request payment to several recipients at once, e.g.
monero:A;B?tx_amount=1;2&recipient_name=x;y(used by split-tip pages such as XMRChat). Stack Wallet currently can't parse these, so scanning one leaves an invalid address and no amount.AddressUtils.parsePaymentUrisplits the;-separated addresses, amounts and names intoPaymentUriData.recipients, requiring one amount (and, if given, one name) per address. Callers opt in withallowMultipleRecipients, so screens that take a single address reject these URIs instead of dropping recipients.confirm_transaction_view.dartis also run throughdart formatfor the changed-files format check.Tested with new unit and widget tests, and on Android by scanning a two-recipient QR code (recipient list, locked total, Clear). Not yet tested with a funded wallet through to broadcast.