build(nvmrc): bump Node.js version from 20 to 22 [PP-1545] - #4
Merged
Conversation
Node 20 reaches EOL 2026-04-30. CI (build, commitlint workflows) picks this up via node-version-file, so no other changes needed. PP-1545
avinash-vllbh
marked this pull request as ready for review
August 24, 2026 14:49
Updates CODEOWNERS and OpsLevel catalog.yaml to reflect the product-pages team, which owns the Catalog application that consumes this package (PLP/PDP rendering). PP-1545
- Exclude committed lib/ build output from ESLint (was never added to .gitignore, so every PR failed lint on generated code formatting, and the test suite never actually ran in CI). - Remove "Run module tests", "Run integration tests", and "Run benchmark" steps from build.yml: they exercise esm/*.mjs and dist/*.js UMD bundles that haven't been built since prepublishOnly was scoped to CJS-only, and a benchmark/ directory that no longer exists in this repo. - Remove size-limit.yml: checks the same dead UMD dist bundle. - Remove assign-reviewer.yml: auto-assigned the upstream OSS maintainer as reviewer, which doesn't apply now that this fork is owned internally by product-pages. PP-1545
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stakeholder Overview (learn more)
Node 20 reaches end-of-life on 2026-04-30. This bumps the repo's pinned Node version to 22 LTS, transfers ownership to the product-pages team, and gets CI actually running (and passing) the test suite for the first time on this fork.
Risk Estimate (learn more)
✅ Negligible risk!
Changes
Click to expand!
.nvmrcfrom20to22. ThebuildandcommitlintGitHub Actions workflows pick this up automatically vianode-version-file: .nvmrc; no other config references the Node version (noenginesfield inpackage.json, no Dockerfile).CODEOWNERSand.customink/catalog.yamlnow point atproduct-pages(owns the Catalog app that consumes this package) instead offunnelcake.buildworkflow failed before reaching tests, so:lib/build output from ESLint (it was never in.gitignore, so generated code failed prettier and blocked every run at the lint step).test:esm,test:integration, andbenchmarksteps frombuild.yml: they exerciseesm/*.mjsand UMDdist/bundles that are no longer built (prepublish is CJS-only on this fork) and abenchmark/directory that doesn't exist here.size-limit.yml(checks the same dead UMD bundle) andassign-reviewer.yml(auto-assigned the upstream OSS maintainer as reviewer).Notes
Published package (
@customink/html-react-parser) is consumed bycustomink/catalogandcustomink/next-frontend(apps/catalog). This is a CI/tooling-only change and does not affect published package behavior or consumers.