fix: check dest_path when filtering watchdog reload events - #872
Merged
craigbarratt merged 1 commit intoSep 11, 2026
Merged
Conversation
Member
|
Thank for the PR - looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #871
Editors that save atomically (temp file +
os.replace/rename— e.g.Blueprint Studio) surface as aFileMovedEventwheresrc_pathis the temp file name anddest_pathis the real script path.check_eventonly checkedsrc_path, so these saves were silently ignored and the reload never fired.Now both
src_pathanddest_pathare checked against the allowed suffixes.Testing
check_eventcurrently has no dedicated tests - the watchdog wiring itself is mocked out everywhere it's touched. Given the fix is a one-line, low-risk check (also inspectdest_pathfor moved events), I kept this PR minimal rather than doing an unrelated refactor to makecheck_eventindependently testable. Happy to extract it to a module-level function and add unit tests if you'd like coverage for this specific case.