Skip to content

fix(orchestrate): resolve test CLI paths with fileURLToPath #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SurefireStudios wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −5
Open

fix(orchestrate): resolve test CLI paths with fileURLToPath #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions orchestrate/skills/orchestrate/scripts/__tests__/comment-cli.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,15 @@ import { describe, expect, test } from "bun:test";
import { spawnSync } from "node:child_process";
import { mkdtempSync, rmSync, writeFileSync } from "node:fs";
import { tmpdir } from "node:os";
import { join } from "node:path";
import { dirname, join } from "node:path";
import { fileURLToPath } from "node:url";

import { loadKickoffThreadTsOrBail } from "../cli/comments.ts";

const TEST_SLACK_CHANNEL = "C123TEST";

const CLI_PATH = new URL("../cli.ts", import.meta.url).pathname;
const SCRIPTS_DIR = new URL("..", import.meta.url).pathname;
const CLI_PATH = fileURLToPath(new URL("../cli.ts", import.meta.url));
const SCRIPTS_DIR = dirname(CLI_PATH);

describe("comment CLI", () => {
test("Refuses to post without --task or --thread-ts", () => {
Expand Down
6 changes: 5 additions & 1 deletion orchestrate/skills/orchestrate/scripts/__tests__/kickoff-dedupe.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
import { describe, expect, test } from "bun:test";
import { spawnSync } from "node:child_process";
import { dirname } from "node:path";
import { fileURLToPath } from "node:url";

const SCRIPTS_DIR = new URL("..", import.meta.url).pathname;
const SCRIPTS_DIR = dirname(
fileURLToPath(new URL("../cli.ts", import.meta.url))
);

import {
findActiveRootPlanner,
Expand Down
3 changes: 2 additions & 1 deletion orchestrate/skills/orchestrate/scripts/__tests__/prompt-plan-validation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,13 @@ import { spawnSync } from "node:child_process";
import { mkdtempSync, rmSync, writeFileSync } from "node:fs";
import { tmpdir } from "node:os";
import { join } from "node:path";
import { fileURLToPath } from "node:url";

function runPromptWithPlan(plan: unknown): ReturnType<typeof spawnSync> {
const workspace = mkdtempSync(join(tmpdir(), "orchestrate-plan-migration-"));
writeFileSync(join(workspace, "plan.json"), JSON.stringify(plan, null, 2));

const cliPath = new URL("../cli.ts", import.meta.url).pathname;
const cliPath = fileURLToPath(new URL("../cli.ts", import.meta.url));
try {
return spawnSync(
process.execPath,
Expand Down