(WIP) Phantom token v3 updates - DPoP, general improvements and minor breaking changes - #13
Open
gary-archer wants to merge 7 commits into
Open
(WIP) Phantom token v3 updates - DPoP, general improvements and minor breaking changes#13gary-archer wants to merge 7 commits into
gary-archer wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some new features, maintenance, minor breaking changes etc for a new major version.
DPoP CHANGES
Support a scheme parameter for API routes, so that DPoP will work something like this:
Support opaque access tokens sent from clients like this:
I also updated www-authenticate responses to match the scheme, as follows.
I now return the
erroranderror_descriptionparameter, which is more standard.Also, we use the more standard
invalid_tokenas the error code, whereas previously we usedunauthorized.I added some tests for the new scheme parameter and made sure all existing tests still pass.
MAINTENANCE CHANGES
standard-credentials-modein configuration.CONFIGURATION BEST PRACTICE UPDATES
access_by_lua_blockinstead ofrewrite_by_lua_blockto run before proxy_pass.apply_default_configurationmethod to set default values.DOCUMENTATION