Add EXIF photo importer - #72
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Temporary-file ownership and below-sea-level altitude handling can produce failed imports or incorrect metadata.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds an EXIF-based importer for geotagged JPEGs and JPEG archives.
Changes:
- Imports GPS points and photo metadata.
- Supports ZIP extraction, warnings, cache keys, and image attachments.
- Adds EXIFR and importer specs.
File summaries
| File | Description |
|---|---|
lib/spatial_features/importers/exif_photo.rb |
Implements EXIF photo importing. |
lib/spatial_features.rb |
Registers the importer. |
spatial_features.gemspec |
Adds EXIFR dependency. |
spec/lib/spatial_features/importers/exif_photo_spec.rb |
Tests importer behavior. |
Review details
- Files reviewed: 4/6 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
Remote filenames, cache invalidation, and direct factory usage have unresolved correctness and API issues.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 5/7 changed files
- Comments generated: 3
- Review effort level: Balanced
3d1044a to
0b2b198
Compare
There was a problem hiding this comment.
🟡 Changes recommended
ZIP staging can overwrite source entries, and basename-less remote URLs produce unstable cache keys.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 9/11 changed files
- Comments generated: 2
- Review effort level: Balanced
Restore the tree to 4482103 as requested for the initial ZIP photo workflow. Defer staged tempfile ownership, remote filename handling, and filename-aware caching until production usage warrants them.
Releases the two commits merged since 3.12.0: - 66d4859 Add EXIF photo importer (#72) - d366ac3 Return the owning Tempfile from Download.open_each (#73) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LwZduP5HbaZc6i2hoJwFJ5
What
Adds
SpatialFeatures::Importers::ExifPhotofor importing geotagged JPEGs as point features.The importer:
importable_image_paths.ImportErrorpath.Testing
Uses the real Nikon D7500 sample photos from the issue, including the five-photo ZIP.
The sample archive is approximately 42 MB and is included because the issue calls for fixtures produced by the real camera
rather than imitated files.
Follow-up
This PR only adds the importer to
spatial_features. ThePhotoMapLayer, uploader allowlists, attachment wiring,permissions, and popup will be implemented in the application repository.
Part of: https://github.com/culturecode/stolo_connect/issues/2025