Skip to content

docs: reconcile table chart Style tab options with the shipped UI#11320

Open
igorlukanin wants to merge 1 commit into
masterfrom
igor/cub-2478-table-docs-reconcile
Open

docs: reconcile table chart Style tab options with the shipped UI#11320
igorlukanin wants to merge 1 commit into
masterfrom
igor/cub-2478-table-docs-reconcile

Conversation

@igorlukanin

Copy link
Copy Markdown
Member

Summary

Reconciles the table chart docs with the current Style tab UI. The page described several controls that no longer match what ships:

  • Display as is a segmented Value / Bars / Sparkline toggle (was documented as a dropdown; "Inline bars" is now "Bars").
  • The Style options / Colors section described a "Font size" control and a copy-palette-JSON menu that the table chart does not have. Replaced with the actual per-section formatting toolbars (color, bold/italic/underline, alignment, overflow), the Values row toggles (row numbers / hover / banding), and the per-section Reset in each section header.
  • Borders: documented the new sync-widths link toggle; corrected "Reset to default at the bottom of the section" to the section-header Reset.

Docs-only; no code changes.

Test plan

  • Prose reviewed against the running Style tab
  • MDX code fences balanced; no broken tables

@igorlukanin
igorlukanin requested a review from keydunov as a code owner July 21, 2026 23:07
@claude

claude Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 29s —— View job


Code review

Docs-only reconciliation of docs-mintlify/docs/explore-analyze/charts/chart-types/table.mdx with the shipped Style tab. Reviewed the full diff against origin/master.

Verdict: LGTM — no blockers.

Notes (nits only)
  • Style/consistency: writing is clear, matches Mintlify tone, and follows the "surgical edit" guidance in docs-mintlify/CLAUDE.md. No new pages, no padding.
  • MDX integrity: tables are balanced, no code fences opened/closed incorrectly, no broken component tags. The removed JSON code block was orphaned copy anyway.
  • Terminology: "Bars" (renamed from "Inline bars") is applied consistently in both the Display-as row and the sparkline row. The section heading ### Inline bars (line 114) is intentionally left as-is — that's fine as an anchor + concept name, but worth confirming with the team whether the heading should also become Bars to fully match the UI toggle. Low priority; either choice is defensible.
  • Anchors: no existing #colors anchor is preserved. If anything external linked to the old ### Colors subsection (line ~216 pre-change), those links now 404 within the page. Unlikely to matter for an internal Style-tab subheading, but flagging.
  • Nit: line 211 is a long single sentence listing six sections. Optional — could be a bulleted list for scannability, but the current prose is fine.

Nothing to change unless the team wants the ### Inline bars heading renamed or a {#colors} anchor preserved.

• [Branch](https://github.com/cube-js/cube/tree/igor/cub-2478-table-docs-reconcile)

@mintlify

mintlify Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
cubed3 🟢 Ready View Preview Jul 21, 2026, 11:09 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@mintlify

mintlify Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
cubed3 🟡 Building Jul 21, 2026, 11:07 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant