feat(task_1): create the "Greeting" feature#31
Open
AlexanderEnin wants to merge 2 commits intoAlexanderEninfrom
Open
feat(task_1): create the "Greeting" feature#31AlexanderEnin wants to merge 2 commits intoAlexanderEninfrom
AlexanderEnin wants to merge 2 commits intoAlexanderEninfrom
Conversation
AlexanderEnin
requested review from
IgorGursky,
Melancholic,
algorithm108 and
trioletas
algorithm108
approved these changes
Sep 2, 2025
|
|
||
| public String greet() { | ||
| long openTasksCount = | ||
| this.todoService.getAllTodos().stream().filter(task -> !task.completed()).count(); |
Collaborator
There was a problem hiding this comment.
No need to use "this" inside method. this makes sense only in constructor to differ it from constructor parameter
Ref for convention:
https://docs.oracle.com/javase/tutorial/java/javaOO/thiskey.html#:~:text=Within%20an%20instance%20method%20or,a%20constructor%20by%20using%20this%20.
| long openTasksCount = | ||
| this.todoService.getAllTodos().stream().filter(task -> !task.completed()).count(); | ||
|
|
||
| return String.format("Hello from Spring! You have %d open tasks.", openTasksCount); |
Collaborator
There was a problem hiding this comment.
How do you think can we also handle plural/singular form of "task" ? 1 task, 2 tasks e.t.c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.