Add entity relationship diagram for Social Work provider data model#1660
Conversation
|
Warning Review limit reached
More reviews will be available in 34 minutes and 29 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (5)
📝 WalkthroughWalkthroughConsolidates per-app ChangesPipeline Architecture Doc Consolidation
Security Controls and Data Model Design Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Poem
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@backend/social-work-app/docs/design/provider-data-model-erd.mmd`:
- Around line 121-137: The INVESTIGATION entity definition in the ERD is missing
the licenseTypeAbbreviation field, which is referenced in the sort-key pattern
on line 122 and used by the accessor code in provider_record_util.py. Add the
licenseTypeAbbreviation field to the INVESTIGATION entity field list as a string
type, positioning it logically with the other license-related fields
(licenseType and licenseScope) to ensure the data model accurately reflects all
fields used in the sort key and application code.
In `@backend/social-work-app/docs/design/README.md`:
- Around line 371-372: The document contains a broken internal link at lines
371-372 that references the anchor
`#license-identity-jurisdiction--licensetype--licensescope`, but this section
header does not exist in the document. The referenced content about license
identity and scope composition is located in lines 238-245 under the "Record
Types in Detail" section without its own dedicated header. Either create a new
section header titled "License Identity" (or similar) in the Data Model section
and place it near the existing content about license identity to match the
anchor being referenced, or update the link at lines 371-372 to point to the
correct existing section anchor where this content is actually documented.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0fdde07f-0568-48ad-99a0-9060bfc14875
⛔ Files ignored due to path filters (6)
backend/compact-connect/docs/design/pipeline-architecture.pdfis excluded by!**/*.pdfbackend/cosmetology-app/docs/design/advanced-provider-search.pdfis excluded by!**/*.pdfbackend/cosmetology-app/docs/design/pipeline-architecture.pdfis excluded by!**/*.pdfbackend/social-work-app/docs/design/advanced-provider-search.pdfis excluded by!**/*.pdfbackend/social-work-app/docs/design/pipeline-architecture.pdfis excluded by!**/*.pdfbackend/social-work-app/docs/design/provider-data-model-erd.pngis excluded by!**/*.png
📒 Files selected for processing (7)
backend/compact-connect/docs/design/README.mdbackend/cosmetology-app/docs/design/README.mdbackend/cosmetology-app/docs/design/pipeline-architecture.mdbackend/social-work-app/docs/design/README.mdbackend/social-work-app/docs/design/pipeline-architecture.mdbackend/social-work-app/docs/design/provider-data-model-erd.mmddocs/pipeline-architecture.md
💤 Files with no reviewable changes (2)
- backend/social-work-app/docs/design/pipeline-architecture.md
- backend/cosmetology-app/docs/design/pipeline-architecture.md
ChiefStief
left a comment
There was a problem hiding this comment.
Looks good, the second code rabbit comment looks valid though
|
@jlkravitz This is ready for your review. Thanks |
jlkravitz
left a comment
There was a problem hiding this comment.
This looks great. Thanks for cleaning up and consolidating the docs. The mermaid diagram is very useful and synthesizes the data model nicely. Great work!
@isabeleliassen Good to merge.
This adds requested documentation to outline the provider/license data model for Social work to illustrate the relationships between providers and the various record types associated with them.
This also removes outdated diagrams for pipeline design and consolidates the pipeline architecture docs at the top level of the project, since all compact share a similar CI/CD pipeline design and deployment process.
Testing List
yarn test:unit:allshould run without errors or warningsyarn serveshould run without errors or warningsyarn buildshould run without errors or warningsbackend/compact-connect/tests/unit/test_api.pyrun compact-connect/bin/download_oas30.pyCloses #1643
Summary by CodeRabbit