fix: constrain CI dependencies#64
Open
al-munazzim wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the current red CI dependency resolution without conflicting with Specter Desktop's pinned runtime environment.
<2.3becauseFlask-SQLAlchemy==2.5.1imports Flask internals removed in Flask 2.3+Werkzeug<3as a test-only dependency, since Specter Desktop currently pinsWerkzeug==3.0.3bdkpython==0.32.1, because latestbdkpython==3.0.0breakstests/test_bdk.pyFixes #63
Specter Desktop compatibility
Specter Desktop currently pins:
This PR keeps the runtime constraint compatible with Specter Desktop by only adding
Flask<2.3to Spectrum's runtime requirements.Werkzeug<3is intentionally limited to Spectrum's[test]extra, so normal Specter Desktop installs are not forced away from their pinnedWerkzeug==3.0.3.Test plan
Fresh local venv on Python 3.11:
Resolved key versions:
Targeted tests:
Full suite: