feat: bring in a lot more state types and data#148
Merged
Conversation
BREAKING CHANGE: Several states/modes/operations/etc have been renamed to better align with OmniLogic internal values
cryptk
force-pushed
the
feat_more_omnitypes
branch
from
ddd7107 to
9b85cfd
Compare
BREAKING CHANGE: Many items that previously returned a raw int value now parse a proper enum value. Specifically Chlorinator operating_state, ColorLogicLight special_effect, Heater why_on, Pump why_on
cryptk
force-pushed
the
feat_more_omnitypes
branch
from
f6ff7c0 to
584e75a
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Several states/modes/operations/etc have been renamed to better align with OmniLogic internal values
BREAKING CHANGE: Many items that previously returned a raw int value now parse a proper enum value.
Specifically Chlorinator operating_state, ColorLogicLight special_effect, Heater why_on, Pump why_on
This brings in a LOT more data into omnitypes.py and renames several things to align the library naming with OmniLogic naming.