-
Notifications
You must be signed in to change notification settings - Fork 194
docs(glossary): update the Glossary articles for Crowdin and Crowdin … #778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rohalskyy
wants to merge
1
commit into
main
Choose a base branch
from
glossary-updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file removed
BIN
-57.3 KB
src/assets/screenshots/crowdin/localization-resources/glossary_add_concept.png
Binary file not shown.
Binary file modified
BIN
+2.06 KB
(100%)
...sets/screenshots/crowdin/localization-resources/glossary_add_concept_dialog.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+13.2 KB
(120%)
...sets/screenshots/crowdin/localization-resources/glossary_add_concept_editor.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-68 KB
src/assets/screenshots/crowdin/localization-resources/glossary_concepts_view.png
Binary file not shown.
Binary file removed
BIN
-77.3 KB
src/assets/screenshots/crowdin/localization-resources/glossary_create_glossary.png
Binary file not shown.
Binary file removed
BIN
-20 KB
.../screenshots/crowdin/localization-resources/glossary_create_glossary_dialog.png
Binary file not shown.
Binary file removed
BIN
-44.5 KB
...ets/screenshots/crowdin/localization-resources/glossary_delete_all_concepts.png
Binary file not shown.
Binary file removed
BIN
-43.6 KB
src/assets/screenshots/crowdin/localization-resources/glossary_edit_concept.png
Binary file not shown.
Binary file removed
BIN
-49.4 KB
...assets/screenshots/crowdin/localization-resources/glossary_share_glossaries.png
Binary file not shown.
Binary file modified
BIN
+10.5 KB
(110%)
src/assets/screenshots/crowdin/localization-resources/glossary_term_hover.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-65.2 KB
src/assets/screenshots/crowdin/localization-resources/glossary_terms_view.png
Binary file not shown.
Binary file removed
BIN
-91 KB
src/assets/screenshots/crowdin/localization-resources/glossary_upload_download.png
Binary file not shown.
Binary file removed
BIN
-25.7 KB
src/assets/screenshots/enterprise/localization-resources/glossary_add_concept.png
Binary file not shown.
Binary file modified
BIN
+6.34 KB
(110%)
...s/screenshots/enterprise/localization-resources/glossary_add_concept_dialog.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-60.3 KB
...assets/screenshots/enterprise/localization-resources/glossary_concepts_view.png
Binary file not shown.
Binary file removed
BIN
-87 KB
...sets/screenshots/enterprise/localization-resources/glossary_create_glossary.png
Binary file not shown.
Binary file removed
BIN
-36.5 KB
...reenshots/enterprise/localization-resources/glossary_create_glossary_dialog.png
Binary file not shown.
Binary file removed
BIN
-36.3 KB
.../screenshots/enterprise/localization-resources/glossary_delete_all_concepts.png
Binary file not shown.
Binary file removed
BIN
-26 KB
src/assets/screenshots/enterprise/localization-resources/glossary_edit_concept.png
Binary file not shown.
Binary file removed
BIN
-65.1 KB
...ets/screenshots/enterprise/localization-resources/glossary_share_glossaries.png
Binary file not shown.
Binary file removed
BIN
-50.5 KB
src/assets/screenshots/enterprise/localization-resources/glossary_terms_view.png
Binary file not shown.
Binary file removed
BIN
-80.8 KB
...sets/screenshots/enterprise/localization-resources/glossary_upload_download.png
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is too aggressive screenshots deletion now :)
For example, this screenshot shows the location of an option in a dropdown menu (highlighted). This type of screenshot should probably be allowed because it's more than just a visual capture of a screen, it points to something.
First, let's agree on a policy for screenshots.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it might look like one, because we had a vast number of screenshots that duplicated what the text already clearly explained.
Regarding this particular one, I deleted it because the step right next to it already says to click the particular icon and lists the options (Upload / Download / Download filtered), so it felt like a repeat.
But sure, if you want to keep this kind of screenshot, I'll bring it back.
In general, I only deleted screenshots that just repeated the text (e.g., buttons, simple dialogs, plain tables) and kept the ones that show something text can't (the new concept dialog, the Editor states, the import column mapping). Where I dropped a "where is it" screenshot, I covered the location in the step text.
I've drafted a screenshot policy based on industry best practices. Still polishing it, will add it to CONTRIBUTING.md so we have it there. Let's agree on that, then I'll recheck the deletions against it.