feat(applications): add support for new endpoints#268
Open
innomaxx wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #268 +/- ##
============================================
+ Coverage 93.30% 93.41% +0.11%
- Complexity 1840 1870 +30
============================================
Files 169 172 +3
Lines 4969 5048 +79
============================================
+ Hits 4636 4715 +79
Misses 333 333 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a new ApplicationApi surface to the PHP client to support Crowdin’s Applications API, including application data CRUD and application installation management (issue #170, and also covering the application data endpoints described in #159).
Changes:
- Introduces
src/CrowdinApiClient/Api/ApplicationApi.phpwith methods for application data (GET/POST/PUT/DELETE/PATCH) and installations (list/install/get/delete/edit). - Adds new models
ApplicationDataandApplicationInstallation. - Registers the new API service on
Crowdinand adds PHPUnit coverage for the new API/model behavior.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/CrowdinApiClient/Api/ApplicationApi.php |
New API wrapper for application data + installation endpoints. |
src/CrowdinApiClient/Model/ApplicationData.php |
New model for arbitrary application data payloads. |
src/CrowdinApiClient/Model/ApplicationInstallation.php |
New model for application installation resources with patchable fields. |
src/CrowdinApiClient/Crowdin.php |
Registers application as a first-class API service. |
tests/CrowdinApiClient/Api/ApplicationApiTest.php |
Adds API-level tests for new endpoints. |
tests/CrowdinApiClient/Model/ApplicationDataTest.php |
Adds model test coverage for ApplicationData. |
tests/CrowdinApiClient/Model/ApplicationInstallationTest.php |
Adds model test coverage for ApplicationInstallation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
@andrii-bodnar please review and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #170
Please merge only after #159