Repository navigation
Conversation
The embedded and embedded-claim project fixtures had the same name and repository, so both built xpkg.crossplane.io/example/itproject_render and loaded it into the shared Docker daemon. Their tests run in parallel, so one could render with the other fixture's function and fail. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Jonathan Ogilvie <jonathan.ogilvie@sumologic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Gives the
embedded-claimproject fixture its own package name and repository, so its tests no longer collide with theembeddedfixture's.The two fixtures had the same
crossplane-project.yamlname and repository, and each has afunctions/renderfunction. Both therefore builtxpkg.crossplane.io/example/itproject_renderand loaded it into the one Docker daemon the integration tests share.TestSimulatePinnedClaimChangedFunctionand the tests on theembeddedfixture run in parallel, so one could render with the other fixture's function.When that happened, the claim test validated the wrong downstream type and failed with
resource scope validation failed. That's the failure on #519's CI. The XR test could fail the same way.Run together with
-count=3, the colliding tests failed in 1 of 3 iterations on main. With this change, a run of the same tests over 4 iterations passed every time.The change renames the fixture's project to
it-project-claim, its repository toxpkg.crossplane.io/example/itprojectclaim, and its Function toexample-itprojectclaimrender. No test code changes. The other project fixtures build no functions, so they can't collide this way.I have:
RunRan the affected integration tests together with./nix.sh flake checkto ensure this PR is ready for review.-count=3instead; CI runs the full suite.Added or updated unit tests.Test fixture change only.Linked a PR or a docs tracking issue to document this change.No user-facing change.AddedNot a backport candidate.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.
🤖 Generated with Claude Code