validate: Recognize Kubernetes built-in resources#197
Open
ihopenre-eng wants to merge 1 commit into
Open
Conversation
Signed-off-by: ihopenre-eng <247072151+ihopenre-eng@users.noreply.github.com>
ihopenre-eng
requested review from
a team,
jcogilvie and
tampakrap
as code owners
July 16, 2026 10:05
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughBuilt-in Kubernetes resources recognized by the client scheme now validate as valid without CRD schemas. Tests cover core ChangesBuilt-in resource validation
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
crossplane resource validatecurrently reports built-in Kubernetes resources as missing schemas because it only looks for matching CRD/XRD schemas.This change falls back to the canonical client-go Kubernetes scheme when custom schema lookup misses. Recognized built-in GVKs are treated as valid, while unknown custom GVKs continue to report
missingSchema. Regression coverage includes both a corev1/Secretand anapps/v1/Deployment.Fixes #195
Validation
go test ./pkg/validate -count=1cmd/crossplane/validatetests except the upstream Windows-onlyTestLocalCacheExists/DoesNotExistfixturego vet ./pkg/validategolangci-lint run --no-config ./pkg/validate/...(0 issues)git diff --checkTestLocalCacheExists/DoesNotExistfails on Windows because its expected path uses/; the same failure reproduces at clean upstream commit5342ad7. Nix is unavailable locally, and the repository's pinned golangci-lint 2.11.4 rejects the current.golangci.ymlbecausegoconst.ignore-testsis no longer supported.I have:
Run./nix.sh flake checkto ensure this PR is ready for review.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Summary by CodeRabbit