Feat: Improve auto-sync error handling and user guidance - #242
Closed
ivke995 wants to merge 5 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
davidabram
reviewed
Aug 27, 2026
| .stdin(Stdio::null()) | ||
| .stdout(Stdio::null()) | ||
| .stderr(Stdio::null()); | ||
| .stderr(Stdio::inherit()); |
Member
There was a problem hiding this comment.
detached execution and inherited stderr are a nono
Classify automatic sync failures by typed origin while preserving technical sources for observability and manual sync behavior. Render deterministic recovery guidance and update the durable CLI contracts. Co-authored-by: SCE <sce@crocoder.dev>
Make detached automatic sync failures observable without blocking post-commit hooks. Mark automatic invocations internally, inherit stderr while keeping stdin/stdout null, and render typed runtime diagnostics for launcher failures. Co-authored-by: SCE <sce@crocoder.dev>
Automatic post-commit synchronization needs one stable, actionable runtime diagnostic while retaining technical causes for observability. Preserve owned user-error message strings during app rendering and document the typed failure guidance, stderr behavior, manual retry path, and unchanged fail-open boundaries. Co-authored-by: SCE <sce@crocoder.dev>
Make post-commit automatic Agent Trace synchronization wait for its one-shot child while preserving fail-open behavior, command boundaries, and diagnostic ownership. Document the synchronous completion boundary and intentional latency trade-off. Co-authored-by: SCE <sce@crocoder.dev>
ivke995
force-pushed
the
feat/auto-sync-failure-guidance
branch
from
August 31, 2026 15:27
8c8de9c to
d4f3e1d
Compare
Keep automatic-sync diagnostics visible without allowing the child to inherit the caller's stderr descriptor. Pipe and drain child stderr with wait_with_output, then forward captured bytes through the parent while preserving synchronous completion, command configuration, and fail-open behavior. Co-authored-by: SCE <sce@crocoder.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.