fix(tools): make RAG file extension detection case-insensitive - #6755
Open
Kyou12138 wants to merge 1 commit into
Open
fix(tools): make RAG file extension detection case-insensitive#6755Kyou12138 wants to merge 1 commit into
Kyou12138 wants to merge 1 commit into
Conversation
DataTypes.from_content() compared path.endswith(ext) against a lowercase-only map, so .PDF/.CSV/.DOCX were misclassified as text (or website for URLs). Lowercase the path before matching. Closes crewAIInc#6399
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughChangesRAG file-type detection
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6399.
DataTypes.from_content()matched file extensions with case-sensitivepath.endswith(ext)against a lowercase-only map. Paths/URLs such asReport.PDFordata.CSVwere misclassified as plain text (orwebsitefor URLs), so binary documents were chunked/embedded as raw bytes instead of parsed text.This is common on Windows, scanner exports, and many enterprise document pipelines.
Change
Lowercase the path (or URL path segment used for extension matching) before comparing against the extension map so detection is case-insensitive for all registered types (PDF, DOCX, CSV, …).
Tests
Added
test_data_types_from_content.pycovering:How to test
Notes
Related open PRs may address the same issue; this change is intentionally minimal (normalize once at match time) with focused unit coverage.