fix: display agent result when human_input=True regardless of verbose setting#6169
Conversation
When human_input=True but verbose=False, CrewAI shows the 'Provide feedback on the Final Result above' prompt but the result was never displayed. The _show_logs method gated the result rendering on agent.verbose or crew.verbose, but the human feedback gate fires purely on human_input=True. This fix adds ask_for_human_input to the verbose check so results are always displayed when human feedback is required. Closes crewAIInc#6072
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughIn ChangesHuman Input Verbose Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
When
human_input=Truebutverbose=False, CrewAI shows the "Provide feedback on the Final Result above" prompt but the result was never displayed. The operator is asked to approve output they cannot see.Root Cause
crew_agent_executor.py::_show_logsgates the result rendering onagent.verbose or crew.verbose, but the human feedback gate fires purely onhuman_input=Truewith no relationship to verbose.Fix
Added
ask_for_human_inputto the verbose check in_show_logs. Whenhuman_inputis active, the result is always displayed regardless of the verbose setting.Before
After
Testing
Minimal reproduction from the issue (#6072):
Before fix: shows feedback prompt but no result.
After fix: result is displayed before the feedback prompt.
Closes #6072
Summary by CodeRabbit
Release Notes