-
-
Notifications
You must be signed in to change notification settings - Fork 71
Add Smithsonian fetch #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
oree-xx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
oree-xx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be LOGGER.info("Fetching media and record counts from internet archive") at line 131.
oree-xx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! This is good to go.
Fixes
Description
Add Smithsonian fetch script
Technical details
Example
smithsonian_1_metrics.csv(click to expand)Table created with command and manually added deliminator row:
Example
smithsonian_2_units.csv(click to expand)Table created with command and manually added deliminator row:
Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin