Prevent stale GraphQL responses in the static cache

[timkelty]

GraphQL responses could be stored in the static cache without the element dependencies needed to invalidate them. Changes to queried elements would not purge those responses, leaving stale content cached until it expired.

Ensure statically cached GraphQL responses are invalidated when their queried elements change. This workaround can be removed after craftcms/cms#19508 reaches Cloud's minimum supported Craft version.

[Copilot]

Pull request overview

Addresses stale static-cache entries caused by GraphQL responses being cached without element dependencies by temporarily disabling Craft’s GraphQL caching while Elements::startCollectingCacheInfo() is active, ensuring static-cache invalidation remains correct until the upstream Craft fix is available.

Changes:

• Register craft\services\Gql before/after execute query event handlers in StaticCache to toggle enableGraphqlCaching off only while collecting cache info.
• Track and restore the prior enableGraphqlCaching value via a new $graphqlCaching instance property.
• Add a unit test to verify GraphQL caching is only disabled during cache-info collection.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/StaticCache.php	Hooks into Craft GQL query lifecycle to disable GraphQL caching only while collecting element cache dependencies, then restores prior setting.
tests/unit/StaticCacheTest.php	Adds coverage for the new GraphQL caching toggle behavior during cache-info collection.

Suppressed comments (1)

tests/unit/StaticCacheTest.php:638

• This helper reflects a private method but does not call ReflectionMethod::setAccessible(true). Invoking a private method without setting accessibility will fail.

    private function handleAfterExecuteGqlQuery(StaticCache $staticCache): void
    {
        $method = new ReflectionMethod($staticCache, 'handleAfterExecuteGqlQuery');
        $method->invoke($staticCache, new \yii\base\Event());
    }

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.