feat: provider selection and document OCR UX - #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates the remaining unmerged provider-selection and document/OCR work.
Included
Framework graph work is intentionally out of scope for this PR: React, Next, React Router, TanStack, Vite, universal framework evidence/resolution, conservative ambiguity handling, render relations, route stages, client/server boundaries, file-set matching, framework fixtures, qualification scripts, and framework-specific VS Code/task-context plumbing are excluded.
Generated local
.vercelstate and screenshot artifacts are excluded.Verification
CARGO_TARGET_DIR=/Volumes/Workspace/crabbuild-target/compass-session-all-pr cargo check --workspace --all-targets --lockedCARGO_TARGET_DIR=/Volumes/Workspace/crabbuild-target/compass-session-all-pr cargo test -p compass-core --lib --locked(80 passed)CARGO_TARGET_DIR=/Volumes/Workspace/crabbuild-target/compass-session-all-pr cargo test -p compass-output --lib --locked(57 passed)CARGO_TARGET_DIR=/Volumes/Workspace/crabbuild-target/compass-session-all-pr cargo test -p compass-files --lib --locked(13 passed)npm run typecheck:jsnpm run test:js(42 viewer files/215 tests, 43 VS Code files/141 tests, 88 browser tests)node scripts/check_viewer_assets.mjssh scripts/check_product_boundary.shcargo fmt --all -- --checkstill reports the pre-existing one-line cfg formatting drift incrates/compass-ocr/src/engine.rs; the focused Clippy command is also blocked by the pre-existingassert!(false)test assertion incrates/compass-core/src/task_context.rs.