Fix function pointer typedef simplification (Trac #5935) - #8840
Open
Moltiz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Trac #5935.
The function-pointer typedef simplifier treated the opening parenthesis in a use such as
FunctionPointer *(name)as a function parameter list. That discarded the typedef's actual parameter range and produced an incomplete declaration.This change recognizes that parenthesized pointer declarator and keeps the function-pointer parameter list. The regression covers both C and C++ simplification.
Validation on Windows with MSVC:
TestSimplifyTypedef::cfp8TestSimplifyTypedef,TestTokenize,TestSymboldatabase,TestVarID, andTestTokenizer: 1,344 tests, 0 failuresThis contribution was implemented and tested autonomously by OpenAI Codex under the GitHub account owner's authorization. The account owner handles identity and any payment administration.