Workshop crates cleanup

.cursor/rules/workshop-architecture.mdc

@@ -8,18 +8,18 @@ alwaysApply: false
 
 ## One-way dependency graph
 
-- Dependencies flow one way: shell -> features -> services -> vocabulary. Never add a dependency from a lower tier to a higher one. If Cargo rejects a cycle, the design is wrong, not the graph.
-- Tiers: vocabulary (`workshop-protocol`, `workshop-support`, `workshop-registry`) <- services (`workshop-gateway`, `workshop-status`, `workshop-menu`) <- features (`workshop-sessions`, `workshop-workspace`) <- shell (`workshop-server`).
+- Dependencies flow one way: server -> features -> services -> vocabulary. Never add a dependency from a lower tier to a higher one. If Cargo rejects a cycle, the design is wrong, not the graph.
+- Tiers: vocabulary (`workshop-protocol`, `workshop-support`, `workshop-registry`) <- services (`workshop-gateway`, `workshop-status`, `workshop-menu`) <- features (`workshop-sessions`, `workshop-workspace`) <- server (`workshop-server`).
 - Crates in the same tier never depend on each other. They meet through `workshop-protocol` wire types and `workshop-registry` proxy slots.
 - Every `workshop-*` crate's `lib.rs` opens with a `//!` doc carrying a `## Invariants` marker that lists what the crate may depend on and what it may not. Read it before adding an import.
 - `lib.rs` is a facade only: crate docs, crate-level attributes, `mod` declarations, and `pub use` re-exports. No logic.
 
 ## Registry pattern
 
-- Subsystems self-register into `workshop-registry` proxy slots: routes, state handles, background tasks, push channels, and shutdown handles. The shell composes the registry; it does not wire subsystems by name.
+- Subsystems self-register into `workshop-registry` proxy slots: routes, state handles, background tasks, push channels, and shutdown handles. The server composes the registry; it does not wire subsystems by name.
 - Unregistered slots are graceful no-ops. Never add a hard dependency on an optional subsystem.
 - Registration handles are `#[must_use]`; registry traits are sealed so only workshop crates implement them.
 
 ## File ceiling
 
-- No file exceeds 500 lines. If an edit would push a file past 500, split first, then edit. `cargo test -p build-xtask` enforces the ceiling, the tier graph, and lint inheritance over the Rust files in the workshop crates carrying the marker; the Tauri shell (the `workshop` crate) is exempt until the headless agent mode plan.
+- No file exceeds 500 lines. If an edit would push a file past 500, split first, then edit. `cargo test -p build-xtask` enforces the ceiling, the tier graph, and lint inheritance over the Rust files in the workshop crates carrying the marker; the desktop app (the `workshop` crate) is exempt until the headless agent mode plan.

.cursor/rules/workshop-spa.mdc

@@ -11,7 +11,7 @@ alwaysApply: false
 - The package at `crates/workshop/ui/` is a sibling of the `crates/workshop/server/` crate that builds and serves it. `src/` has three layers: `base/` (lifecycle, events, paths, the `WorkshopPart` base class), `services/` (DOM-free registries and services), and `parts/` (feature directories; every panel extends `base/workshop-part.ts`).
 - Feature-based directories under `parts/` (`parts/agent/`, `parts/editor/`, `parts/layout/`, `parts/menu/`, `parts/take/`, `parts/stt/`, `parts/chrome/`, `parts/status/`, `parts/workspace/`, `parts/gateway/`). Shared code lives in `services/` or `base/`; shared UI assets (boot-loaded icons) live in `parts/shared/`; design tokens live in `tokens/`.
 - Barrel exports: every directory has an `index.ts`. Lazy directories export `register()` installing commands, menu items, panel factories, and socket subscriptions.
-- The boot shell (`main.ts`, `services/`, `base/`) loads immediately. Feature directories load via dynamic `import()` on first activation. Lazy-loaded panels never import the boot shell.
+- The entry bundle (`main.ts`, `services/`, `base/`) loads immediately. Feature directories load via dynamic `import()` on first activation. Lazy-loaded panels never import the entry bundle.
 - Registration, not central wiring: panel types, menu items, services, socket handlers, keyboard shortcuts, and lifecycle disposal self-register through the panel, menu/command, and service registries.
 
 ## CSS colocation and tokens

.github/workflows/ci.yml

@@ -179,7 +179,7 @@ jobs:
       - name: Stage Gateway sidecar
         run: node tools/stage-gateway-sidecar.mjs stage --target x86_64-pc-windows-msvc --source target/debug/promptforge-gateway.exe
 
-      # workshop-server-api is the shell's re-export view of workshop-server,
+      # workshop-server-api is the desktop app's re-export view of workshop-server,
       # so it runs in this partition with the crates it fronts and stays
       # out of the workspace-wide jobs like them.
       - name: Clippy (workshop)
@@ -199,6 +199,11 @@ jobs:
       - name: Doctests (workshop)
         run: cargo test --doc -p workshop -p workshop-server -p workshop-server-api
 
+      - name: Docs (workshop-server, private items)
+        env:
+          RUSTDOCFLAGS: -D warnings
+        run: cargo doc --locked --no-deps -p workshop-server --document-private-items
+
       - name: Test Gateway process ownership races
         shell: bash
         run: |

.github/workflows/nightly.yml

@@ -201,13 +201,13 @@ jobs:
               src="target/release/promptforge-gateway$ext"
               ;;
           esac
-          mkdir -p crates/workshop/shell/binaries
-          cp "$src" "crates/workshop/shell/binaries/promptforge-gateway-$triple$ext"
+          mkdir -p crates/workshop/desktop/binaries
+          cp "$src" "crates/workshop/desktop/binaries/promptforge-gateway-$triple$ext"
 
       - name: Build the app
         uses: tauri-apps/tauri-action@84b9d35b5fc46c1e45415bdb6144030364f7ebc5 # v0
         with:
-          projectPath: crates/workshop/shell
+          projectPath: crates/workshop/desktop
           args: ${{ matrix.args }} --config tauri.nightly.conf.json
 
       - name: Upload the installers

.github/workflows/release-workshop.yml

@@ -164,8 +164,8 @@ jobs:
               src="target/release/promptforge-gateway$ext"
               ;;
           esac
-          mkdir -p crates/workshop/shell/binaries
-          staged="crates/workshop/shell/binaries/promptforge-gateway-$triple$ext"
+          mkdir -p crates/workshop/desktop/binaries
+          staged="crates/workshop/desktop/binaries/promptforge-gateway-$triple$ext"
           cp "$src" "$staged"
           output=$("$staged" --version)
           version="${{ needs.prepare.outputs.version }}"
@@ -180,15 +180,15 @@ jobs:
           TAURI_SIGNING_PRIVATE_KEY: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY }}
           TAURI_SIGNING_PRIVATE_KEY_PASSWORD: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY_PASSWORD }}
         with:
-          projectPath: crates/workshop/shell
+          projectPath: crates/workshop/desktop
           args: ${{ matrix.args }}
 
       - name: Build the unsigned temporary app
         if: github.event_name == 'workflow_dispatch'
         id: temporary-build
         uses: tauri-apps/tauri-action@84b9d35b5fc46c1e45415bdb6144030364f7ebc5 # v0
         with:
-          projectPath: crates/workshop/shell
+          projectPath: crates/workshop/desktop
           args: ${{ matrix.args }} --config tauri.nightly.conf.json
 
       - name: The signed build has the workspace version
@@ -292,7 +292,7 @@ jobs:
             Select-Object -First 1
           if (-not $exe) { throw "promptforge-workshop.exe not found after install" }
           # The gateway ships as an externalBin sidecar; a default (all
-          # components checked) silent install must lay it beside the shell.
+          # components checked) silent install must lay it beside the desktop app.
           $gateway = @("$env:LOCALAPPDATA", "$env:ProgramFiles", "${env:ProgramFiles(x86)}") |
             ForEach-Object { Get-ChildItem $_ -Recurse -Filter promptforge-gateway.exe -ErrorAction SilentlyContinue } |
             Select-Object -First 1
@@ -304,7 +304,7 @@ jobs:
           $output
           $configDir = Join-Path $env:USERPROFILE ".promptforge"
           New-Item -ItemType Directory -Path $configDir -Force | Out-Null
-          # A default install lays the gateway beside the shell, so boot
+          # A default install lays the gateway beside the desktop app, so boot
           # launches it instead of using an explicit endpoint. A minimal
           # gateway.toml keeps that first boot free of STT model downloads;
           # the dummy workshop.toml endpoint remains the fallback when no
@@ -360,15 +360,15 @@ jobs:
           cp -R "/Volumes/PromptForge/PromptForge.app" /tmp/PromptForge.app
           hdiutil detach "/Volumes/PromptForge" -quiet
           # The bundle holds two executables (the gateway ships via
-          # externalBin beside the main binary); pick the shell by name.
+          # externalBin beside the main binary); pick the desktop app by name.
           bin="/tmp/PromptForge.app/Contents/MacOS/promptforge-workshop"
           [ -x "$bin" ] || { echo "promptforge-workshop not in the bundle"; exit 1; }
           version="${{ needs.prepare.outputs.version }}"
           output=$("$bin" --version)
           expected="promptforge-workshop $version"
           [ "$output" = "$expected" ] || { echo "--version printed '$output', expected '$expected'"; exit 1; }
           mkdir -p "$HOME/.promptforge"
-          # A default install lays the gateway beside the shell, so boot
+          # A default install lays the gateway beside the desktop app, so boot
           # launches it instead of using an explicit endpoint. A minimal
           # gateway.toml keeps that first boot free of STT model downloads;
           # the dummy workshop.toml endpoint remains the fallback when no
@@ -407,7 +407,7 @@ jobs:
           package=$(dpkg-deb -f "$deb" Package)
           # The deb holds two executables (the gateway ships via
           # externalBin into /usr/bin beside the main binary); pick the
-          # shell by name.
+          # desktop app by name.
           bin=$(dpkg -L "$package" | grep -E '/usr/bin/promptforge-workshop$' | head -1)
           [ -n "$bin" ] || { echo "no promptforge-workshop in the deb"; exit 1; }
           version="${{ needs.prepare.outputs.version }}"
@@ -421,7 +421,7 @@ jobs:
           output=$("$appimage" --version)
           [ "$output" = "$expected" ] || { echo "AppImage --version printed '$output', expected '$expected'"; exit 1; }
           mkdir -p "$HOME/.promptforge"
-          # A default install lays the gateway beside the shell, so boot
+          # A default install lays the gateway beside the desktop app, so boot
           # launches it instead of using an explicit endpoint. A minimal
           # gateway.toml keeps that first boot free of STT model downloads;
           # the dummy workshop.toml endpoint remains the fallback when no

.github/workflows/workshop-installer-smoke.yml

@@ -5,8 +5,8 @@ on:
     paths:
       - .github/workflows/workshop-installer-smoke.yml
       - crates/build-workshop/**
-      - crates/workshop/shell/installer.nsi
-      - crates/workshop/shell/tauri*.conf.json
+      - crates/workshop/desktop/installer.nsi
+      - crates/workshop/desktop/tauri*.conf.json
       - tools/stage-gateway-sidecar.mjs
   workflow_dispatch:
 
@@ -40,7 +40,7 @@ jobs:
       - name: Compile unsigned debug NSIS installer
         uses: tauri-apps/tauri-action@84b9d35b5fc46c1e45415bdb6144030364f7ebc5 # v0
         with:
-          projectPath: crates/workshop/shell
+          projectPath: crates/workshop/desktop
           args: --debug --bundles nsis --config tauri.nightly.conf.json
 
       - name: Remove Gateway sidecar

.gitignore

@@ -19,8 +19,8 @@
 /crates/workshop/ui/dist/
 /crates/gateway/config-ui/ui/dist/
 # tauri-build's generated ACL schemas, regenerated on every workshop build.
-/crates/workshop/shell/gen/
+/crates/workshop/desktop/gen/
 # The gateway sidecar staged for bundle.externalBin by CI before
-# `tauri build` (crates/workshop/shell/tauri.conf.json); a build artifact.
-/crates/workshop/shell/binaries/
+# `tauri build` (crates/workshop/desktop/tauri.conf.json); a build artifact.
+/crates/workshop/desktop/binaries/
 /plan-dist-manifest.json