Skip to content

Label the unpinned MSVC arm64 CI leg 14.52 - #488

Merged
sgerbino merged 1 commit into
cppalliance:developfrom
sgerbino:pr/msvc-arm64-14.52
Nov 16, 2026
Merged

sgerbino merged 1 commit into
cppalliance:developfrom
sgerbino:pr/msvc-arm64-14.52

Conversation

@sgerbino

Copy link
Copy Markdown
Collaborator

The MSVC 14.51: C++20 (arm64) job fails on every run at the Configure MSVC step:

Expected MSVC 14.51 for ARM64, got: Microsoft (R) C/C++ Optimizing Compiler Version 19.52.37029 for ARM64

The windows-11-vs2026-arm image (win11-vs2026-arm64/20261112.217) ships VS 18.12, whose default toolset is 14.52. Its only side-by-side MSVC toolset is 14.44, so the leg cannot be pinned back to 14.51. This leg has no msvc_toolset pin and builds with the image default. The step that checks the compiler against the matrix version caught the change as intended.

Changes

  • ci: label the unpinned MSVC arm64 leg 14.52. The entry in .github/compilers.json now says 14.52. The job is renamed to MSVC 14.52: C++20 (arm64). The B2 toolset stays msvc-14.5, and the pinned 14.44 arm64 leg is unchanged.

The x64 MSVC 14.51 legs on windows-2025-vs2026 are not pinned either. They will fail the same way when that image moves to 14.52.

Testing

  • generate-matrix.py produces the same MSVC jobs as before, apart from the new name.
  • No branch protection requires the old job name.
  • Only this PR's arm64 run can confirm the fix.

The windows-11-vs2026-arm image now defaults to MSVC 14.52 and no
longer installs 14.51 side by side, so the leg cannot be pinned back.
The Configure MSVC step rejected the stale label on every run.
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Next included review available in 25 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 25299eb and 821b9b4.

Files selected for processing: 1

  • .github/compilers.json
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@greptile-apps

greptile-apps Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

Updates the unpinned ARM64 MSVC entry from 14.51 to 14.52.

  • The ARM64 MSVC job now expects version 14.52.

No actionable issues found. The Windows job was not run during this review.

Reviews (1) · Last reviewed commit: "ci: label the unpinned MSVC arm64 leg 14..." · Reviewed by Greptile

@cppalliance-bot

Copy link
Copy Markdown

An automated preview of the documentation is available at https://488.capy.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-11-16 16:50:34 UTC

@cppalliance-bot

Copy link
Copy Markdown

GCOVR code coverage report https://488.capy.prtest3.cppalliance.org/gcovr/index.html
LCOV code coverage report https://488.capy.prtest3.cppalliance.org/genhtml/index.html
Coverage Diff Report https://488.capy.prtest3.cppalliance.org/diff-report/index.html

Build time: 2026-11-16 17:02:30 UTC

@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.47%. Comparing base (25299eb) to head (821b9b4).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #488   +/-   ##
========================================
  Coverage    98.47%   98.47%           
========================================
  Files          135      135           
  Lines         7364     7364           
========================================
  Hits          7252     7252           
  Misses         112      112           
Flag Coverage Δ
linux 98.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25299eb...821b9b4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sgerbino
sgerbino merged commit e4b38b6 into cppalliance:develop Nov 16, 2026
42 checks passed
@sgerbino
sgerbino deleted the pr/msvc-arm64-14.52 branch November 16, 2026 18:00
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Beast2 Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants