[2026-06 LWG Motion 18] P2019R9 Thread attributes#9121
Open
eisenwave wants to merge 2 commits into
Open
Conversation
Comment on lines
+1549
to
+1550
| %FIXME: ordinary literal encoding? Literal encoding of T? What is "THE literal encoding"? | ||
| \exposid{name} is interpreted as a string in the literal encoding. |
Contributor
There was a problem hiding this comment.
At this moment, I believe the literal encoding must be the ordinary literal encoding because T must be char. I wish we don't need a follow-up LWG issue for this.
Suggested change
| %FIXME: ordinary literal encoding? Literal encoding of T? What is "THE literal encoding"? | |
| \exposid{name} is interpreted as a string in the literal encoding. | |
| \exposid{name} is interpreted as a string in the ordinary literal encoding. |
Member
Author
There was a problem hiding this comment.
At this point it cannot be anything else, yeah. I'm wondering in which direction we want to resolve this though, and that depends on how likely support for more character types is in the future.
If we say "ordinary literal encoding" now, we will need to change that wording if more support is added.
| name_hint(name_hint&&) = delete; | ||
| name_hint(const name_hint&) = delete; | ||
| private: | ||
| basic_string_view<T> @\exposid{name}@; // \expos |
Contributor
There was a problem hiding this comment.
Maybe we should rename this to name_, possibly in a follow-up commit or PR. Same for (size ->) size_.
Member
Author
|
@jwakely some LWG input needed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9105
Also fixes cplusplus/papers#817