Repository navigation
fix(rest): refuse props edits on create doors, honour definitions_only, drop tracker numbers - #216
Open
Andrei Kvapil (kvaps) wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
rd create and rg spawn decoded override_props, delete_props and
delete_namespaces and dropped them, answering success for an edit that
never happened. A create has no props to edit yet, and neither
golinstor nor python-linstor sends these fields there, so a non-empty
one is now refused with 400 naming the field and where props go
instead.
rg spawn also ignored definitions_only and placed replicas anyway; it
now stops after the definition and its volumes.
Error messages, events and log lines no longer carry internal tracker
numbers ("Bug 174", "pending Phase 12"). A test walks the shipped
string literals and fails on one. The src_snap_name refusal says what
is unsupported instead of naming a phase, and the stale comment that
called the field a no-op is gone.
Fixes #210
Fixes #211
Assisted-by: LLM
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
`linstor rg spawn-resources --definition-only` placed replicas before the fix. An L6 cli-matrix cell and an L7 replay check that the definition and its volume exist and that no replica appears over a hold window. Assisted-by: LLM Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
Andrei Kvapil (kvaps)
force-pushed
the
fix/create-spawn-prop-fields
branch
from
October 24, 2026 21:53
a963c86 to
8a65508
Compare
Andrei Kvapil (kvaps)
marked this pull request as ready for review
October 24, 2026 22:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rd createandrg spawndecodedoverride_props,delete_propsanddelete_namespacesand dropped them, answering success for an edit that never happened. A create has no props to edit yet, and neither golinstor nor python-linstor sends these fields on either call, so a non-empty one is now refused with 400 naming the field and where props go instead. With #190 this covers what #202 lists for spawn.partialis still decoded and not acted on; that predates this PR and stays open.rg spawnalso ignoreddefinitions_only(linstor rg spawn --definitions-only) and placed replicas anyway. It now stops after the definition and its volumes.Operator-facing strings no longer carry internal tracker numbers: errors, events and log lines said things like "(Bug 174)" or "pending Phase 12". The
src_snap_namerefusal now says what is not supported, and the comment that still called that field a no-op is gone. A test walks every string literal inpkg,internalandcmdand fails on a tracker number, so new ones don't creep back.Stacked on #190.
Fixes #210
Fixes #211
Testing
definitions_onlybranch were reverted in turn, and the named test fails each time.rg-spawn-definitions-only) pin the definitions-only spawn at operator-CLI level. Not run on a stand.go test ./...: green apart from the knownpkg/restshutdown flake.