[Andrei Kvapil (kvaps)]

Stacked on #190.

A clone of a source with volumes takes clone-<target> on the source, and nothing ever deleted it, so once a clone existed the source could never be deleted through the API, which refuses a definition that has snapshots. rd d of a clone now reaps that snapshot, on both the REST and the CLI door.

Ownership is a prop the clone path stamps, never the name, so an operator's snapshot called clone-<target> is never touched. A snapshot another definition was restored from is kept. The reap marks the snapshot, lists dependents past the cache, and only then deletes; a restore reads its snapshot back past the cache once its definition exists and withdraws on a live mark, on a delete in flight, or on a snapshot that is gone. Whichever of the list and the create comes second sees the other. The store now surfaces DELETE on a snapshot a satellite finalizer still holds, and the snapshot list no longer stamps SUCCESSFUL beside it. A later rd d of the source names what is left and why, including a snapshot whose delete is already in flight, which only needs a retry.

A restore that withdraws takes its definition back through the rollback handshake, so one a retry adopted is left to it. A withdrawal caused only by a reap's mark answers a retryable 409; a snapshot that is gone answers 404. A kept or failed reap is a warning in the answer to the delete.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 10e0263e-94ce-49f9-8725-51f20ff1cd78

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}