-
Notifications
You must be signed in to change notification settings - Fork 24
feat: Add Ink network #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
All contributors have signed the CLA ✍️ ✅ |
📝 WalkthroughWalkthroughThis PR adds the Ink chain to multiple documentation tables and examples, and updates the contract-addresses component by adding an Ink explorer entry, introducing a typed Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/contract-addresses/index.tsx (1)
59-67:⚠️ Potential issue | 🟡 MinorMissing
keyprop on<Link>elements will cause React warnings.When rendering an array of elements via
reduce, each element needs a uniquekeyprop to avoid React reconciliation warnings.🔧 Proposed fix
return chains.reduce( (acc, chain) => { if (acc.length) { acc.push(separator) } - acc.push(<Link to={explorerUrl(chain, address, { urlTrailing })}>{chain}</Link>) + acc.push(<Link key={chain} to={explorerUrl(chain, address, { urlTrailing })}>{chain}</Link>) return acc } , []); }
🤖 Fix all issues with AI agents
In `@docs/cow-protocol/reference/contracts/periphery/README.mdx`:
- Around line 45-56: The MDX array passed to explorerLinks is missing commas
after the "Ink" and "Optimism" entries which breaks parsing; update the array
inside the explorerLinks([...]) call (the list containing "Arbitrum One",
"Avalanche", ..., "Ink", "Lens", "Linea", "Optimism", "Plasma") to include the
missing commas so each string is a separate element and the MDX/JS is valid.
In `@docs/cow-protocol/reference/core/auctions/rewards.md`:
- Line 100: Replace the incorrect token symbol in the Ink reward line: change
the expression "Ink: $$\min\{X.X ~\textrm{XPL}, 6 ~\textrm{COW}\}$$." so that
the placeholder token symbol "XPL" is "ETH" (e.g., "Ink: $$\min\{X.X
~\textrm{ETH}, 6 ~\textrm{COW}\}$$."), preserving the LaTeX formatting and the
rest of the text.
🧹 Nitpick comments (1)
src/components/contract-addresses/index.tsx (1)
70-72: Consider moving theasArrayhelper aboveexplorerLinksfor better readability.While function hoisting makes this work, placing helper functions before their usage improves code flow and readability.
|
I have read the CLA Document and I hereby sign the CLA |
| - Lens: $$10 \;\textrm{GHO}$$ | ||
| - BNB: $$0.04 \;\textrm{BNB}$$ | ||
| - Linea: $$0.0015 \;\textrm{ETH}$$ | ||
| - Linea and Ink: $$0.0015 \;\textrm{ETH}$$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Add Ink network.
Changes
Summary by CodeRabbit
New Features
Documentation