Repository navigation
chore(security): review dependency vulnerabilities - #20
Open
dex-the-ai wants to merge 1 commit into
Open
dex-the-ai wants to merge 1 commit into
dex-the-ai wants to merge 1 commit into
Conversation
- Gemfile: rails ~> 7.1.3 -> ~> 8.1.4, >= 8.1.4.1. Rails 7.1 is end-of-life and the current Rails advisories are only fixed in 8.0.5.2+ / 8.1.4.1+. Dockerfile preinstall updated to match. - docusaurus: @docusaurus/* 3.4.0 -> 3.10.2, npm audit fix, overrides for serialize-javascript ^7.1.4 and tinypool ^2.2.0, engines node >=20. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes 161 of 163 known advisories found by the native tools:
Gemfile.lockis gitignored, so everybundle installresolvesrails ~> 7.1.3to the newest 7.1.x, which today is Rails 7.1.6. bundler-audit reports 28 advisories against that resolution (Action Pack, Action View, Active Storage, Active Support, Action Mailbox), including one critical Active Storage file read/write bug. Rails 7.1 is end-of-life and none of these have a 7.1 fix. Several of the newest ones are not fixed in 7.2 either. The fixed lines are 8.0.5.2+ and 8.1.4.1+. This PR moves the Gemfile togem 'rails', '~> 8.1.4', '>= 8.1.4.1'. The app code andconfig.load_defaults 7.1are unchanged, and the full request-spec suite passes against Capella. The Dockerfile'sgem install rails -v '7.1'preinstall line now uses 8.1.4.1 to match.docusaurus/, npm audit): 135 advisories in the docs build toolchain. Fixed 133 by bumping the exact@docusaurus/*pins 3.4.0 -> 3.10.2 (same major) and runningnpm audit fix(no--force), plus two smalloverrides:serialize-javascript^7.1.4: used by copy-webpack-plugin / css-minimizer at build time. Same API, and 6.x has an RCE advisory with no 6.x fix.tinypool^2.2.0: Docusaurus 3.10 addedtinypool@^1for its optional SSG worker-thread mode, and 1.x has critical prototype-pollution-to-RCE advisories. That mode (future.faster.ssgWorkerThreads) is off in this site, so tinypool isn't loaded at all.engines.nodegoes from>=18.0to>=20.0, because Docusaurus 3.10 needs Node 20. The deploy workflow already uses Node 22.Advisories fixed
Rails gems (bundler-audit, fresh
bundle lockon Ruby 3.4.1)In plain words: XSS in Action View helpers, strong-parameters bypass and session/cookie issues in Action Pack, path traversal / file read / possible RCE in Active Storage (the app does not use Active Storage, but Rails loads it), and ReDoS/XSS in Active Support helpers.
Docs site (
docusaurus/package-lock.json, npm audit)One row per package.
Remaining advisories not fixed
<=4.0.7), and no fix is released. Build-time only.webpack-dev-server->sockjs(docs dev server)docusaurus start, and sockjs doesn't use the affectedbufargument.Validation
bundle lock+bundle-audit check(ruby:3.4.1, current main Gemfile)bundle installwith this Gemfile (ruby:3.4.1)RAILS_ENV=test bundle exec rake couchbase:setup_indexes(Capella)bundle exec rspec spec/requests/api/v1(same as CI, live Capella travel-sample)CI=true bundle exec rake rswag:specs:swaggerizeswagger.yamlnot committed)bundle-audit checkafterrails s+ Playwright: Swagger UI at/api-docs, then GET /api/v1/airlines/{id} "Try it out" withairline_1040-Mile Airreturned from Capellanpm ci,npm run build,npm run typecheck(Node 26)DOCUSAURUS_SSG_WORKER_THREAD_COUNT=2 npx docusaurus buildnpx docusaurus serve+ Playwright on a tutorial pagenpm auditbefore / afterThe docs build warns about a broken link to
/docs/introfrom the navbar/home page. That comes from existing content (onBrokenLinks: 'warn'), not from this change.Evidence
Swagger UI on Rails 8.1.4.1

GET /api/v1/airlines/airline_10 against Capella

Walkthrough video: walkthrough.webm
Docs site (Docusaurus 3.10.2 build)

Overlapping Dependabot PRs
~> 8.1.1) is superseded by this PR. This PR uses~> 8.1.4, >= 8.1.4.1, the first 8.1 release with all current fixes, and is validated against Capella.Risk / rollback
config.load_defaultsstays at 7.1, so framework defaults don't change. BecauseGemfile.lockisn't committed, users already get the newest matching gems on every install.To roll back, revert this commit.
Reviewer + Slack notification
tutorials.json; the repo has no CODEOWNERS file).Hermes Kanban: board couchbase-examples, task t_5ccc3afa
🤖 Generated with Claude Code