Conversation
github-actions
bot
added
A-deps
|
Bencher Report| Branch | remove-chumsky |
| Testbed | github-ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| empty_router/empty_router | 📈 view plot 🚷 view threshold | 6.39 ms(+5.87%)Baseline: 6.03 ms | 7.34 ms (87.02%) |
| json_api/json_api | 📈 view plot 🚷 view threshold | 1.18 ms(+12.34%)Baseline: 1.05 ms | 1.25 ms (94.57%) |
| nested_routers/nested_routers | 📈 view plot 🚷 view threshold | 1.07 ms(+10.59%)Baseline: 0.97 ms | 1.14 ms (93.92%) |
| single_root_route/single_root_route | 📈 view plot 🚷 view threshold | 1.03 ms(+11.27%)Baseline: 0.93 ms | 1.10 ms (93.83%) |
| single_root_route_burst/single_root_route_burst | 📈 view plot 🚷 view threshold | 18.25 ms(+3.35%)Baseline: 17.66 ms | 21.07 ms (86.63%) |
There was a problem hiding this comment.
Pull request overview
Removes the workspace-level chumsky dependency and associated feature wiring, and drops the previously-added Windows linker/rustflags workaround in Cargo configs.
Changes:
- Remove
chumskyfrom workspace dependencies and fromcot’semailfeature/dependency list. - Delete Windows-specific
.cargo/config.tomlworkaround (both in repo root and the project template). - Update the project generator to no longer copy the template
.cargo/config.toml.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
cot/Cargo.toml |
Drops optional chumsky dep and removes it from the email feature. |
Cargo.toml |
Removes chumsky from [workspace.dependencies]. |
Cargo.lock |
Updates lockfile to reflect removal of chumsky from the resolved graph. |
.cargo/config.toml |
Removes Windows-specific linker/rustflags workaround. |
cot-cli/src/project_template/.cargo/config.toml |
Deletes the template’s Windows-specific cargo config workaround. |
cot-cli/src/new_project.rs |
Stops copying the template .cargo/config.toml into newly generated projects. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const PROJECT_FILES: [(&str, &str); 10] = [ | ||
| project_file!("Cargo.toml.template"), | ||
| project_file!("Cargo.lock.template"), | ||
| project_file!("bacon.toml"), |
There was a problem hiding this comment.
new_project copies Cargo.lock.template, but the current template lock file still contains chumsky (and is pinned to cot 0.5.0). This means freshly generated projects will still carry the dependency/version pins this PR is trying to remove. Please regenerate cot-cli/src/project_template/Cargo.lock.template from the updated template project (or stop shipping a lock template if it’s not meant to be kept in sync).
This removes the chumsky dependency, which was really just a `lettre` dependency, pinned to a specific version to avoid minimal version dependency issues. Also, this removes the workaround for rust-lang/rust#141626 which should be no longer needed now.
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
This removes the chumsky dependency, which was really just a
lettredependency, pinned to a specific version to avoid minimal version dependency issues.Also, this removes the workaround for rust-lang/rust#141626 which should be no longer needed now.
Type of change