Resolve Parquet shard count via bucket index to optimize storage calls#7648
Open
SungJin1212 wants to merge 1 commit into
Open
Resolve Parquet shard count via bucket index to optimize storage calls#7648SungJin1212 wants to merge 1 commit into
SungJin1212 wants to merge 1 commit into
Conversation
…e calls Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
parquet-shard-count-from-bucket-index
branch
from
f7b225e to
0fdab66
Compare
yeya24
reviewed
Jun 26, 2026
| shardCounts := make(map[string]int, len(blockIDs)) | ||
|
|
||
| if p.bucketIndexEnabled { | ||
| idx, err := bucketindex.ReadIndex(ctx, p.indexBucket, p.userID, p.limits, p.logger) |
Contributor
There was a problem hiding this comment.
This should be cached with some TTL instead? Or we would rather have a separate goroutine to sync bucket index periodically rather than resolving it at query time.
Contributor
There was a problem hiding this comment.
If we use bucketindex.Loader it has built-in caching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR updates the Parquet shard resolution logic to utilize the bucket index, reducing the number of object storage calls.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags