-
Notifications
You must be signed in to change notification settings - Fork 850
querier: support series batching from Store Gateways #7203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
yeya24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should try to upgrade to thanos-io/thanos#8629 to include it as a fix
|
Batched server response is not supported in parquet gateway, correct? I don't think we use the |
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
da0ba70 to
bf66b3e
Compare
yeya24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
1cf3c76 to
f213eb0
Compare
Add
-querier.store-gateway-series-batch-sizeflag to configure the maximum number of series to be batched in a single gRPC response message from Store Gateways.Benchmark results
BenchmarkThanosBucketStores_SeriesBatch
BenchmarkParquetBucketStore_SeriesBatch
Which issue(s) this PR fixes:
Fixes #7202
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]