Fix CI lint failures: upgrade golangci-lint and Go version in CI#51
Draft
Fix CI lint failures: upgrade golangci-lint and Go version in CI#51
Conversation
Copilot
AI
changed the title
[WIP] Add new feature to enhance user experience
No changes: issue lacks actionable requirements
Feb 28, 2026
Replace rulefmt.RuleNode with rulefmt.Rule, convert yaml.Node{Value: x}
to plain string values, update field access from .Expr.Value to .Expr
(and similar for .Record and .Alert), and remove unused yaml imports.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Update go.mod to reference cortex v1.20.1 and go 1.24.0 - Add changelog entries and files for v0.18.1, v0.19.1, v0.20.1 - Fix API changes: rulefmt.RuleNode -> rulefmt.Rule (string fields) - Fix tsdb.NewBlockWriter to use *slog.Logger - Fix dns.Provider.Resolve to include flushOld parameter - Fix bucket.NewClient signature change - Fix objstore.Bucket.Upload signature change - Fix remote.ReadClient.Read API change (returns SeriesSet) - Fix labels.Labels type changes (no longer a slice) - Update ulid to v2 in blockscopy - Update replace directives to match cortex v1.20.1 - Update vendor directory - Update test files for new Rule type API Co-authored-by: CharlieTLe <3375195+CharlieTLe@users.noreply.github.com>
Copilot
AI
changed the title
No changes: issue lacks actionable requirements
Upgrade cortex dependency from v1.18.1 to v1.20.1
Feb 28, 2026
Co-authored-by: CharlieTLe <3375195+CharlieTLe@users.noreply.github.com>
- Update validate_pr.yml to use Go 1.24 matching go.mod requirement - Upgrade golangci-lint from v1.54 to v1.64 (supports Go 1.24) - Upgrade golangci-lint-action from v4 to v6 - Update .golangci.yml: use disable-all with explicit linter list, fix deprecated config options (output.format -> output.formats, errcheck.exclude -> removed) - Rename min/max functions in cmd/sim/main.go to avoid shadowing Go 1.21+ builtins (revive: redefines-builtin-id) - Rename 'new' parameter in CompareNamespaces to 'updated' to avoid shadowing builtin (revive: redefines-builtin-id) - Remove accidentally committed blockgen binary Co-authored-by: CharlieTLe <3375195+CharlieTLe@users.noreply.github.com>
Copilot
AI
changed the title
Upgrade cortex dependency from v1.18.1 to v1.20.1
Fix CI lint failures: upgrade golangci-lint and Go version in CI
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
golangci-lint v1.54 cannot typecheck code targeting Go 1.24 (set in
go.modby the cortex v1.20.1 upgrade), causing falseundefinederrors for vendored packages likekingpin,ulid, andyaml.CI configuration
golangci-lintv1.54 → v1.64,golangci-lint-actionv4 → v6go.modLinter config (
.golangci.yml)output.format→output.formats, removeerrcheck.excludedisable-all: trueso only explicitly listed linters run (matches prior behavior)Code fixes for
revive: redefines-builtin-idmin/max→minFloat64/maxFloat64incmd/sim/main.go(shadow Go 1.21+ builtins)new→updatedparameter inCompareNamespaces(pkg/rules/compare.go)Cleanup
blockgenbinary from prior sessionWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
example.com/tmp/go-build3639953578/b1432/httpmiddleware.test /tmp/go-build3639953578/b1432/httpmiddleware.test -test.testlogfile=/tmp/go-build3639953578/b1432/testlog.txt -test.paniconexit0 -test.timeout=10m0s /tmp/go-build3639953578/b1394/vet.cfg AJ7RQGEA_ .cfg ux_amd64/vet g_.a om/uudashr/iface-test.testlogfile=/tmp/go-build3639953578/b1114/testlog.txt ache/go/1.24.13/-test.paniconexit0 ux_amd64/vet port�� k/cortex-tools/cortex-tools/vend-errorsas estmain.go ux_amd64/vet GOINSECURE GOMOD GOMODCACHE ux_amd64/vet(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.