Fix Trivy CI: upgrade OS packages to patch linux-libc-dev vulnerabilities#90
Merged
Fix Trivy CI: upgrade OS packages to patch linux-libc-dev vulnerabilities#90
Conversation
…ties Add apt-get upgrade -y to both builder and runtime stages of the Dockerfile to pick up security patches for OS-level packages. All 9 CRITICAL/HIGH CVEs (linux-libc-dev) are fixed by upgrading to the latest patched versions from Debian stable. Also switch from apt to apt-get for proper non-interactive usage. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Switch remaining apt → apt-get on line 31 for consistency with the rest of the Dockerfile. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
shawnburke
approved these changes
Mar 15, 2026
| FROM debian:stable-slim AS builder | ||
|
|
||
| RUN apt update && apt install -y protobuf-compiler git wget build-essential | ||
| RUN apt-get update && apt-get upgrade -y && apt-get install -y protobuf-compiler git wget build-essential |
Collaborator
There was a problem hiding this comment.
I think if we put these on separate lines we'll get better caching?
Contributor
Author
There was a problem hiding this comment.
yeah I remembered that trick too but turns out that is antipattern lol. Seperate RUN means new more layers and may increase size of the image
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apt-get upgrade -yto both builder and runtime stages in the Dockerfile to pick up security patches for OS-level packageslinux-libc-devflagged by the Trivy scanapt→apt-getfor proper non-interactive Dockerfile usageTest plan
🤖 Generated with Claude Code