feat(mcp): support VS Code-style variable interpolation in MCP server config - #13036
Open
Onkar-Mane wants to merge 1 commit into
Open
feat(mcp): support VS Code-style variable interpolation in MCP server config#13036Onkar-Mane wants to merge 1 commit into
Onkar-Mane wants to merge 1 commit into
Conversation
… config
Resolve ${workspaceFolder}, ${workspaceFolderBasename}, ${userHome}, and
${env:VAR} in command/args/cwd/env exactly once before a stdio MCP server
is spawned, so configs can reference the active workspace instead of
hardcoding absolute paths.
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for
${workspaceFolder},${workspaceFolderBasename},${userHome}, and${env:VAR}in MCP servercommand/args/cwd/env, resolved once right before the stdio process is spawned.Summary
resolveMcpVariablesutility (core/util/resolveMcpVariables.ts) recursively resolves the variables in strings/arrays/objects, leaving unknown variables and${{ secrets.X }}untouched.MCPConnection.constructStdioTransport, the single choke point for all stdio MCP servers regardless of config source (YAML or JSON).resolveCwd's absolute-path check to usepath.isAbsoluteinstead of a Unix-onlycharAt(0) === "/"check, needed for${workspaceFolder}-derived Windows paths to be recognized correctly.${workspaceFolder}intentionally stays unresolved (rather than falling back to homedir) for remote workspaces, to avoid silently pointing configs at the wrong directory.Test plan
core/util/resolveMcpVariables.test.ts- 18 unit testscore/context/mcp/MCPConnection.vitest.ts- new wiring/integration teststsc --noEmitclean.continue/mcpServers/*.yamlusing${workspaceFolder}in cwd/args/env