Skip to content

fix(vscode): prevent edit_existing_file from silently failing without error feedback #12756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rodboev wants to merge 3 commits into from
Closed

fix(vscode): prevent edit_existing_file from silently failing without error feedback #12756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a448188
fix(vscode): prevent edit_existing_file from silently failing without…
rodboev Jun 18, 2026
63376a3
fix(gui): prevent false success on early close and timeout race (#17)
rodboev Jun 18, 2026
942d69f
fix(gui): track done-phase lifecycle to prevent false edit failures (…
rodboev Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions extensions/vscode/src/diff/vertical/manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,13 @@ export class VerticalDiffManager {
// Get the current editor fileUri/range
let editor = vscode.window.activeTextEditor;
if (!editor) {
// Emit closed status so the tool call doesn't hang
void this.webviewProtocol.request("updateApplyState", {
streamId,
status: "closed",
numDiffs: 0,
toolCallId,
});
return;
}
const fileUri = editor.document.uri.toString();
Expand Down Expand Up @@ -254,6 +261,15 @@ export class VerticalDiffManager {

if (!diffHandler) {
console.warn("Issue occurred while creating new vertical diff handler");
// Emit closed status so the tool call doesn't hang
void this.webviewProtocol.request("updateApplyState", {
streamId,
status: "closed",
numDiffs: 0,
fileContent: editor.document.getText(),
filepath: fileUri,
toolCallId,
});
return;
}

Expand Down Expand Up @@ -305,6 +321,13 @@ export class VerticalDiffManager {

const editor = vscode.window.activeTextEditor;
if (!editor) {
// Emit closed status so the tool call doesn't hang
void this.webviewProtocol.request("updateApplyState", {
streamId,
status: "closed",
numDiffs: 0,
toolCallId,
});
return;
}

Expand Down Expand Up @@ -333,6 +356,15 @@ export class VerticalDiffManager {

if (!diffHandler) {
console.warn("Issue occurred while creating vertical diff handler");
// Emit closed status so the tool call doesn't hang
void this.webviewProtocol.request("updateApplyState", {
streamId,
status: "closed",
numDiffs: 0,
fileContent: editor.document.getText(),
filepath: fileUri,
toolCallId,
});
return;
}

Expand Down
Loading
Loading