Skip to content

fix(openai-adapters): keep reasoning deltas out of assistant content#11127

Open
siewcapital wants to merge 1 commit intocontinuedev:mainfrom
Siew-s-Capital:fix/vercel-reasoning-delta-11069
Open

fix(openai-adapters): keep reasoning deltas out of assistant content#11127
siewcapital wants to merge 1 commit intocontinuedev:mainfrom
Siew-s-Capital:fix/vercel-reasoning-delta-11069

Conversation

@siewcapital
Copy link

@siewcapital siewcapital commented Mar 6, 2026

Summary

  • map reasoning-delta stream parts to delta.reasoning_content in the Vercel stream converter
  • keep delta.content reserved for actual assistant text deltas
  • add regression checks for both single-event conversion and mixed stream conversion

Why

reasoning-delta was previously being emitted as content, which mixed thinking output into assistant text for Vercel adapter streams.

Testing

  • pnpm exec vitest run src/test/vercelStreamConverter.test.ts (from packages/openai-adapters)

Closes #11069

@siewcapital siewcapital requested a review from a team as a code owner March 6, 2026 15:06
@siewcapital siewcapital requested review from sestinj and removed request for a team March 6, 2026 15:06
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! note CLA requirement. Also non-blocking nitpick but avoid any type if possible.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Mar 10, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Vercel stream converter maps reasoning-delta to content instead of reasoning_content

2 participants