Skip to content

Add detect-secrets scanning - #115

Merged
gcgoncalves merged 6 commits into
mainfrom
bh/add_detect_secrets
Sep 9, 2026
Merged

Add detect-secrets scanning#115
gcgoncalves merged 6 commits into
mainfrom
bh/add_detect_secrets

Conversation

@brian-hussey

@brian-hussey brian-hussey commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Add detect-secrets scanning

Closes internal: contextforge-org/internal_issues#624

What this does

Wires IBM's hardened detect-secrets fork into the project as a first-class quality gate, matching the pattern already established in mcp-context-forge.

Changes

.secrets.baseline — initial baseline generated and audited; all findings confirmed as false positives (test fixtures, example values, generated API types).

package.json — two new developer scripts:

  • npm run secrets:scan — re-scans the repo and updates .secrets.baseline
  • npm run secrets:audit — interactive audit of findings (mark false positives)

.husky/pre-commitdetect-secrets-hook added alongside lint-staged; blocks commits that introduce new unaudited secrets.

README.md — new Secrets Scanning subsection under Code Quality with usage instructions and troubleshooting guidance for the two most common failure modes; secrets:scan and secrets:audit added to the Available Scripts table.

Signed-off-by: Brian Hussey <brian.hussey@ie.ibm.com>
…ck .secrets.baseline

Signed-off-by: Brian Hussey <brian.hussey@ie.ibm.com>
Signed-off-by: Brian Hussey <brian.hussey@ie.ibm.com>
Signed-off-by: Brian Hussey <brian.hussey@ie.ibm.com>
@gcgoncalves

Copy link
Copy Markdown
Contributor

THANKS!

Signed-off-by: Brian Hussey <brian.hussey@ie.ibm.com>
@brian-hussey

Copy link
Copy Markdown
Contributor Author

I'm trying to sort out the github actions to defend us, but I can't figure out where changes are slipping in.
If this doesn't pan out, I'll remove the github action and we can have a static file that we update periodically and that should get us over the check we need it for.

@brian-hussey

Copy link
Copy Markdown
Contributor Author

@gcgoncalves I'm going to remove the github action piece for this at the moment and I think that will satisfy the check to get our internal scans working for the moment.

Signed-off-by: Brian Hussey <brian.hussey@ie.ibm.com>
@gcgoncalves
gcgoncalves merged commit 9b34738 into main Sep 9, 2026
5 checks passed
@gcgoncalves
gcgoncalves deleted the bh/add_detect_secrets branch September 9, 2026 15:43
@brian-hussey brian-hussey self-assigned this Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants