fix: guard against null/undefined in getTag function#251
Merged
nadeem-cs merged 2 commits intodevelopmentfrom Feb 13, 2026
Merged
fix: guard against null/undefined in getTag function#251nadeem-cs merged 2 commits intodevelopmentfrom
nadeem-cs merged 2 commits intodevelopmentfrom
Conversation
- Add null check at the top of getTag to return empty object early, preventing TypeError when Object.entries receives null or undefined (typeof null === "object" in JS, so null slipped through the switch) - Add test cases covering null/undefined field values, null/undefined entries, multiple null fields, and nested null objects (Issue #193) Co-authored-by: Cursor <cursoragent@cursor.com>
Coverage report
Show files with reduced coverage 🔻
Test suite run success412 tests passing in 21 suites. Report generated by 🧪jest coverage report action from 4be5fb6 |
Coverage report
Show files with reduced coverage 🔻
Test suite run success412 tests passing in 21 suites. Report generated by 🧪jest coverage report action from 4be5fb6 |
cs-raj
approved these changes
Feb 12, 2026
cs-raj
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addEditableTagsthrowsTypeError: Cannot convert undefined or null to objectwhengetTagreceivesnullas thecontentparametercontent == null) at the top of thegetTagfunction to return an empty object early, preventingObject.entries(null)from throwingRoot Cause
In JavaScript,
typeof null === "object"evaluates totrue. When a field value isnull, theswitch (typeof value)ingetTagmatchescase "object", and the recursive call togetTag(value, ...)passesnullas thecontentparameter. This causesObject.entries(null)to throw aTypeError.Test plan
getTag(null, 'some.prefix', true, 'en-us', { ...appliedVariants })) no longer throws