Skip to content

chore:[] harden dependency installation - #124

Open
contentful-supply-chain-migrator[bot] wants to merge 1 commit into
mainfrom
repo-migrator/supply-chain-controls
Open

contentful-supply-chain-migrator[bot] wants to merge 1 commit into
mainfrom
repo-migrator/supply-chain-controls

Conversation

@contentful-supply-chain-migrator

Copy link
Copy Markdown

hold new dependency releases for 2 days and disable dependency install scripts

This repository fails the dependency-release-age and ignore-scripts governance controls. This PR makes the changes below.

What changed

hold new dependency releases for 2 days

  • Package manager: pnpm
  • Adds: pnpm-workspace.yaml
  • Before: not set
  • After: minimumReleaseAge: 2880

disable dependency install scripts

  • Package manager: pnpm
  • Edits: pnpm-workspace.yaml
  • Before: not set
  • After: ignoreScripts: true

Read before merging

  • This stops install scripts for this repository and its dependencies. Packages that download or build on install (for example puppeteer, cypress, node-gyp) may break later, in the build or a Docker image. Check CI before merging.

Verification

The dependency-release-age control failed before this change and passes after it, checked against the control's own code at 1dec3b1b on main.
The ignore-scripts control failed before this change and passes after it, checked against the control's own code at 1dec3b1b on main.

Why

The RAPID: Supply Chain Controls adds these controls. See Dependency Release Age Control and Ignore Scripts Control for the per-manager details.

Review

  • Created by the supply-chain migration and labeled supply-chain-rollout. If it is still a draft, mark it ready for review when you want your code owners requested.
  • Merge it through your normal review process. It is not merged automatically.
  • The setting only takes effect on a package manager version that supports it. Where the repository does not pin one, this PR still adds the setting and says so under Read before merging. Repositories where no edit would help are skipped.

Something is broken

Please reach out to the Product Security team, or look at the code that created this PR, and we can work out how to make it migrate every repository correctly.

… install scripts

Setting: dependency-release-age
Package manager: pnpm
Adds: pnpm-workspace.yaml
Before: (not set)
After: minimumReleaseAge: 2880

Control: Dependency Release Age Control (https://contentful.atlassian.net/wiki/spaces/SRT/pages/7107936363)

Setting: ignore-scripts
Package manager: pnpm
Edits: pnpm-workspace.yaml
Before: (not set)
After: ignoreScripts: true
Note: This stops install scripts for this repository and its dependencies. Packages that download or build on install (for example puppeteer, cypress, node-gyp) may break later, in the build or a Docker image. Check CI before merging.

Control: Ignore Scripts Control (https://contentful.atlassian.net/wiki/spaces/SRT/pages/7107117082)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants