Update SchemaReference component to render default values properly#294
Merged
Update SchemaReference component to render default values properly#294
Conversation
✅ Deploy Preview for cai-open-source ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
3 tasks
|
🚀 Deployed on https://deploy-preview-294--cai-open-source.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, some default values are not captured properly in c2pa-rs schema generation.
contentauth/c2pa-rs#1824 addresses this, and this PR leverages the schema-level defaults to display the default values. Where defaults are part of an object, the default just links to that object.
NOTE: This PR includes schema files in
static/schemaswhich are generated using the changes in contentauth/c2pa-rs#1824, however these files will be overwritten when there is a new Rust release. Until contentauth/c2pa-rs#1824 is merged, the schemas won't properly reflect the default values and so the changes in this PR won't work.The main example where this matters is https://deploy-preview-294--cai-open-source.netlify.app/docs/manifest/json-ref/settings-schema.