feat(sdk): resolve ServiceConfig.cwd lazily via callback#1
Merged
Conversation
cwd may now be a `(args: { workspaceDir }) => string | Promise<string>`
callback, resolved at service start when the workspace is populated. A
string (or callback result) is resolved relative to the workspace dir so
a relative path like `packages/web` lands inside the session worktree;
absolute paths pass through. Lets a monorepo preview point its dev server
at the web package detected at start, not the workspace root.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JgccNTPcbCLKrCcBczAqeZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ServiceConfig.cwdmay now be a callback(args: { workspaceDir }) => string | Promise<string>, resolved at service start (when the workspace is populated) instead of statically. Both a string and a callback result are resolved relative to the workspace dir (absolute paths pass through).Why
Lets a service detect its working directory lazily once the workspace exists — e.g. point a monorepo's dev server / sidecar at the web package (
packages/web) rather than the workspace root. Consumed by webmaster's preview stack to fix monorepo sites (the web app isn't at the repo root).Changes
schema.ts:cwd?: string | ((args: ServiceCwdArgs) => string | Promise<string>)+ newServiceCwdArgs { workspaceDir }service.ts: resolve cwd at start (await callback),resolve(workspaceDir, raw)Backward compatible: existing string cwds resolve identically (relative-to-workspace; previously used as-is, which for the existing callers — absolute or workspace-rooted — is unchanged).
🤖 Generated with Claude Code