Use mount_setattr() in bind_mount()#756
Open
xxyzz wants to merge 1 commit into
Open
Conversation
rusty-snake
reviewed
May 31, 2026
| .attr_set = MOUNT_ATTR_NOSUID | (devices ? 0 : MOUNT_ATTR_NODEV) | | ||
| (readonly ? MOUNT_ATTR_RDONLY : 0), | ||
| }; | ||
| if (mount_setattr(dest_fd, "", |
Contributor
There was a problem hiding this comment.
musl does not have a library function for mount_setattr yet. Also older (before 2024?) glibc versions. We should ifdef-provide our own definition.
Signed-off-by: xxyzz <gitpull@protonmail.com>
Were they related somehow? |
Author
No, these actions are just too outdated so I updated them. |
Contributor
|
What was wrong with The code changes have some AI smell to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #754, all tests passed. I also update some GitHub Actions.