Skip to content

ci: declare contents: read on ci.yml and codespell.yml - #296

Merged
samuelkarp merged 1 commit into
containerd:mainfrom
arpitjain099:ci/add-permissions
Aug 19, 2026
Merged

ci: declare contents: read on ci.yml and codespell.yml#296
samuelkarp merged 1 commit into
containerd:mainfrom
arpitjain099:ci/add-permissions

Conversation

@arpitjain099

Copy link
Copy Markdown
Contributor

Two workflows currently inherit the default GITHUB_TOKEN scope:

  • ci.yml (jobs: checks, test-build, linters, tests) — checkout + Go build/test.
  • codespell.yml (job: codespell) — checkout + codespell-project/actions-codespell scan.

Neither pushes commits, opens issues, or calls write APIs. contents: read at the workflow level is the right minimum. codeql.yml in this repo already follows the same workflow-level pattern; this brings the remaining two CI workflows in line.

@arpitjain099

Copy link
Copy Markdown
Contributor Author

Hello, Gentle nudge in case this got buried. Let me know if there's anything I can help move forward. Appreciated.

Both workflows do checkout + build/test (ci.yml) or checkout + codespell
scan (codespell.yml). Neither pushes commits or calls write APIs.
codeql.yml in this repo already declares workflow-level contents: read;
this brings the remaining two in line.

Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
@arpitjain099

Copy link
Copy Markdown
Contributor Author

@samuelkarp this one has been sitting approved since May with all checks passing. Happy to rebase if it has gone stale, otherwise it just needs a merge.

@samuelkarp

Copy link
Copy Markdown
Member

At least 2 approving reviews are required by reviewers with write access.

@samuelkarp samuelkarp moved this to Needs Reviewers in Pull Request Review Aug 13, 2026
@klihub
klihub self-requested a review August 19, 2026 15:29
@github-project-automation github-project-automation Bot moved this from Needs Reviewers to Review In Progress in Pull Request Review Aug 19, 2026
@samuelkarp
samuelkarp merged commit b94b446 into containerd:main Aug 19, 2026
16 checks passed
@github-project-automation github-project-automation Bot moved this from Review In Progress to Done in Pull Request Review Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants