Remove unused functions - #5139
Open
AkihiroSuda wants to merge 1 commit into
Open
Conversation
Remove code that is no longer reachable, as reported by `golang.org/x/tools/cmd/deadcode -test ./...`: - The legacy `testutil.Base`/`testutil.Cmd` test framework (`testutil.NewBase` and friends), superseded by Tigron/nerdtest. - `pkg/testutil/testregistry`, only referenced from a commented-out test. - Unused helpers in `cmd/nerdctl/helpers` (`ComposeUp`, `NewCosignKeyPair`, `CreateBuildContext`). - Unused library functions in `pkg/cmd/container`, `pkg/resolvconf`, `pkg/rootlessutil`, `pkg/internal/filesystem`, and `pkg/api/types/cri`. Also update `docs/testing/README.md` to stop referring to the removed API. Assisted-by: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove code that is no longer reachable, as reported by
golang.org/x/tools/cmd/deadcode -test ./...:testutil.Base/testutil.Cmdtest framework (testutil.NewBaseand friends), superseded by Tigron/nerdtest.pkg/testutil/testregistry, only referenced from a commented-out test.cmd/nerdctl/helpers(ComposeUp,NewCosignKeyPair,CreateBuildContext).pkg/cmd/container,pkg/resolvconf,pkg/rootlessutil,pkg/internal/filesystem, andpkg/api/types/cri.Also update
docs/testing/README.mdto stop referring to the removed API.Assisted-by: Claude Fable 5 noreply@anthropic.com