Skip to content

feat: update blueprint types for array-only multi-module storage#1193

Merged
pyramation merged 2 commits into
mainfrom
feat/multi-storage-module-types
May 19, 2026
Merged

feat: update blueprint types for array-only multi-module storage#1193
pyramation merged 2 commits into
mainfrom
feat/multi-storage-module-types

Conversation

@pyramation
Copy link
Copy Markdown
Contributor

Summary

Updates TypeScript blueprint types to match the multi-storage-module support added in constructive-db PR #1228.

Breaking changes:

  • has_storage removed from BlueprintEntityType — now derived from storage[].length > 0
  • storage changed from BlueprintStorageConfig to BlueprintStorageConfig[] (array-only, no object form)
  • New storage_key field added to BlueprintStorageConfig for multi-module discrimination

Companion to: https://github.com/constructive-io/constructive-db/pull/1228

Review & Testing Checklist for Human

  • Verify BlueprintStorageConfig has storage_key?: string with correct JSDoc
  • Verify BlueprintEntityType.storage is BlueprintStorageConfig[] (array, not single object)
  • Verify has_storage is no longer on BlueprintEntityType
  • Verify b2b-storage preset description references storage array (not has_storage=true)

Notes

  • The generated file also picks up some unrelated type changes (LimitWarning node types) that were already on main but not regenerated. These are not from this PR's changes.
  • The LimitWarningCounterParams/LimitWarningAggregateParams/LimitWarningRateParams build errors in the generated file are pre-existing on main (node types merged but params not yet generated by the static fallback). Not introduced by this PR.

Link to Devin session: https://app.devin.ai/sessions/c0494871633d4beb91f1e16e53c776d1
Requested by: @pyramation

- Remove has_storage from BlueprintEntityType (now derived from storage[].length > 0)
- Change storage from BlueprintStorageConfig to BlueprintStorageConfig[] (array-only)
- Add storage_key field to BlueprintStorageConfig for multi-module support
- Update b2b-storage preset description to reference array format
@devin-ai-integration
Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Start from main's generated file and apply only the storage-related
changes to avoid picking up unmerged node type definitions
(LimitWarning*, EventReferral, etc.) that don't have params generated.
@pyramation pyramation merged commit b8e7296 into main May 19, 2026
37 checks passed
@pyramation pyramation deleted the feat/multi-storage-module-types branch May 19, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant