feat: rename secrets_module → user_state_module and encrypted_secrets_module → user_secrets_module in presets + export pipeline#1188
Merged
Conversation
…s_module to user_secrets_module in presets and export pipeline
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates all references to the old module names after the constructive-db renames:
secrets_moduleuser_state_moduleencrypted_secrets_moduleuser_secrets_moduleModule presets (8 files): Updated
modulesarrays,includes_noteskeys, and description text in all presets (minimal,auth:email,auth:email+magic,auth:sso,auth:passkey,auth:hardened,b2b,b2b:storage).Export pipeline (3 source files): Updated
META_TABLE_ORDER,META_TABLE_CONFIGkeys/table names, SQL queries inexport-meta.ts, and GraphQL query keys inexport-graphql-meta.ts.Tests (2 files): Updated expected module names in
export-meta.test.tsandgraphql-naming.test.ts.All 84 tests in
pgpm/exportpass locally.Review & Testing Checklist for Human
user_state_module/user_secrets_module— passing old names will silently skip provisioning those modules. This is the critical ordering dependency.secrets_moduleorencrypted_secrets_moduleoutside.tsfiles (markdown docs, skill references, CI configs, env vars) that this PR may have missed.auth-email.ts(line 29) — now reads "emails, user state, user secrets, sessions" which is accurate but less intuitive than the old wording. Confirm this reads acceptably.Recommended test plan: Provision a fresh database using one of the updated presets (e.g.
auth:email) against a constructive-db instance that has the renamed modules, and verify thatuser_state_moduleanduser_secrets_moduleboth appear inv_installed.Notes
org_secrets_modulewas already added to the export pipeline in the prior PR (feat: add org_secrets_module to export pipeline #1187, merged). It is not added to any preset here because it is not yet wired intoprovision_database_modulesin constructive-db — it's a standalone module provisioned separately.fullpreset usesmodules: ['all']so it doesn't list individual module names and needed no changes.Link to Devin session: https://app.devin.ai/sessions/af039a166f1c4df4a67704c842540835
Requested by: @pyramation